kyuubi icon indicating copy to clipboard operation
kyuubi copied to clipboard

[KYUUBI #3723] save the SQL session metadata into MetadataManager

Open lightning-L opened this issue 3 years ago • 3 comments

Why are the changes needed?

How was this patch tested?

  • [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible

  • [ ] Add screenshots for manual tests if appropriate

  • [ ] Run test locally before make a pull request

lightning-L avatar Nov 03 '22 07:11 lightning-L

@turboFei

  • SessionData contains duration and idleTime, which is calculated by session lastAccessTime and lastIdleTime, but those two are not stored in the Metadata. How to get duration and idleTime after fetching the session metadata?
  • We could get Resource/ClassName/ClusterManager for session from engine proc builder. But before engine is created, the prod builder is null. Currently I am not sure how to set those values when opening session.
  • The batch session and sql session related operation are mixed in one class(KyuubiSessionManager), do we need a refactor? For example, separate this into KyuubiSessionManager and KyuubiBatchSessionManager.

lightning-L avatar Nov 03 '22 07:11 lightning-L

SessionData contains duration and idleTime, which is calculated by session lastAccessTime and lastIdleTime, but those two are not stored in the Metadata. How to get duration and idleTime after fetching the session metadata?

Seems there is no appropriate solution now.

We could get Resource/ClassName/ClusterManager for session from engine proc builder. But before engine is created, the prod builder is null. Currently I am not sure how to set those values when opening session.

How about leave them empty now?

The batch session and sql session related operation are mixed in one class(KyuubiSessionManager), do we need a refactor? For example, separate this into KyuubiSessionManager and KyuubiBatchSessionManager.

I think it is not needed.

cc @ulysses-you @pan3793

turboFei avatar Nov 03 '22 10:11 turboFei

session rest api is less used.. is it possible to focus on batch api ?

ulysses-you avatar Nov 04 '22 02:11 ulysses-you