kyuubi icon indicating copy to clipboard operation
kyuubi copied to clipboard

Support Flink 1.16

Open pan3793 opened this issue 2 years ago • 6 comments

Why are the changes needed?

Close https://github.com/apache/incubator-kyuubi/issues/3513

Test against Flink 1.16.0 RC0

https://www.mail-archive.com/[email protected]/msg60192.html

How was this patch tested?

  • [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible

  • [ ] Add screenshots for manual tests if appropriate

  • [x] Run test locally before make a pull request

pan3793 avatar Sep 18 '22 18:09 pan3793

Codecov Report

Merging #3514 (48bd470) into master (b2210d9) will decrease coverage by 0.06%. The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #3514      +/-   ##
============================================
- Coverage     52.11%   52.04%   -0.07%     
  Complexity       13       13              
============================================
  Files           485      485              
  Lines         27274    27274              
  Branches       3804     3804              
============================================
- Hits          14213    14196      -17     
- Misses        11687    11702      +15     
- Partials       1374     1376       +2     
Impacted Files Coverage Δ
...client/exception/RetryableKyuubiRestException.java 0.00% <0.00%> (-100.00%) :arrow_down:
.../org/apache/kyuubi/client/RetryableRestClient.java 48.78% <0.00%> (-24.40%) :arrow_down:
...main/java/org/apache/kyuubi/client/RestClient.java 82.75% <0.00%> (-3.45%) :arrow_down:
...ache/kyuubi/operation/KyuubiOperationManager.scala 79.45% <0.00%> (-2.74%) :arrow_down:
.../engine/spark/session/SparkSQLSessionManager.scala 78.48% <0.00%> (-1.27%) :arrow_down:
...n/scala/org/apache/kyuubi/engine/ProcBuilder.scala 80.74% <0.00%> (-0.63%) :arrow_down:
...in/scala/org/apache/kyuubi/config/KyuubiConf.scala 97.29% <0.00%> (-0.08%) :arrow_down:
...g/apache/kyuubi/operation/BatchJobSubmission.scala 74.64% <0.00%> (ø)
...apache/kyuubi/engine/JpsApplicationOperation.scala 77.41% <0.00%> (ø)
...yuubi/server/metadata/jdbc/JDBCMetadataStore.scala 89.96% <0.00%> (+0.69%) :arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov-commenter avatar Sep 18 '22 19:09 codecov-commenter

cc @yanghua @SteNicholas @link3280

pan3793 avatar Sep 19 '22 02:09 pan3793

cc @yanghua @SteNicholas @link3280

+1 for supporting 1.16, can we find a good way to keep 1.14 for a longer time?

yanghua avatar Sep 19 '22 04:09 yanghua

cc @yanghua @SteNicholas @link3280

+1 for supporting 1.16, can we find a good way to keep 1.14 for a longer time?

+1 to keep Flink 1.14 longer, as Flink 1.15 is released only 4 months ago (2022.05), and we have little overhead to maintain 1.14 support.

link3280 avatar Sep 19 '22 06:09 link3280

+1 to keep 1.14,

yaooqinn avatar Sep 19 '22 06:09 yaooqinn

As all guys want to keep support for Flink 1.14, I reverted those parts of the changes.

pan3793 avatar Sep 19 '22 16:09 pan3793

Thanks all for review, merging to master

pan3793 avatar Oct 26 '22 17:10 pan3793