kyuubi icon indicating copy to clipboard operation
kyuubi copied to clipboard

Feature ranger arctic

Open hellojinsilei opened this issue 2 years ago • 6 comments

Why are the changes needed?

adapt arctic table DML& DDL

How was this patch tested?

  • [x] Add some test cases that check the changes thoroughly including negative and positive cases if possible

  • [ ] Add screenshots for manual tests if appropriate

  • [x] Run test locally before make a pull request

hellojinsilei avatar Sep 08 '22 05:09 hellojinsilei

this duplicates https://github.com/apache/incubator-kyuubi/pull/3425, can you split your PRs, for example, command by command? cc @bowenliang123

yaooqinn avatar Sep 08 '22 05:09 yaooqinn

Can you isolate Arctic related commands with in this PR?

I'm trying to cover org.apache.spark.sql.catalyst.plans.logical.v2Commands.scala with org.apache.spark.sql.catalyst.analysis.v2ResolutionPlans.scala in #3425. The challenge is to maintain adaption to compatible with eache version from Spark 3.0 to 3.3 in detailed differences for above and the adaptation with spark operation to hive style operation type.

As for now, it's able to cover basic CRUD operations on input tables. Some obstacle in hand for inputObjs (which also lacks support in current code change of this PR).

bowenliang123 avatar Sep 08 '22 06:09 bowenliang123

@bowenliang123 Could you merge your PR into mine? We have a deadline of 9.12

hellojinsilei avatar Sep 08 '22 06:09 hellojinsilei

Could you have a look a my implementation in #3425? Covering the following v2Commands:

  • CreateTable
  • CreateAsSelect
  • UpdateTable
  • AppendData: Insert Using a SELECT Statement / VALUES / TABLE
  • OverwriteByExpression: Insert Overwrite
  • CacheTable
  • DropTable

All related ut has been tested locally with spark3.3 covering CRUD commands for tables. I think it might be more mature than this pr in some cases as it covers some inputobjects. It should be ready for merge with minor adjustment. You could base on my PR for arctic adoption ASAP.

bowenliang123 avatar Sep 08 '22 07:09 bowenliang123

@bowen It looks like I'm just adding arctic related commands like CreateV2Table and ReplaceArcticData these two commands?

hellojinsilei avatar Sep 08 '22 07:09 hellojinsilei

Yes, I think so. And for Arctic related command , please try to isolate their impacts . As for CreateV2Table in your case, it is not form org.apache.spark.sql.catalyst.plans.logical.v2Commands.scala of Spark.

bowenliang123 avatar Sep 08 '22 07:09 bowenliang123

Thanks for the PR! This PR is being closed due to inactivity. This isn't a judgement on the merit of the PR in any way. If this is still an issue with the latest version of Kyuubi, please reopen it and ask a committer to remove the Stale tag!

Thank you for using Kyuubi!

github-actions[bot] avatar Dec 19 '22 00:12 github-actions[bot]