kyuubi icon indicating copy to clipboard operation
kyuubi copied to clipboard

[KYUUBI #3435] Command should not execute when plan only mode is set to PHYSICAL or EXECUTION

Open lsm1 opened this issue 2 years ago • 6 comments

Why are the changes needed?

close #3435

How was this patch tested?

  • [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible

  • [ ] Add screenshots for manual tests if appropriate

  • [x] Run test locally before make a pull request

lsm1 avatar Sep 07 '22 11:09 lsm1

This change doesn't seem to be compatible with Spark 3.1, can you make it compatible?

wForget avatar Sep 09 '22 07:09 wForget

Codecov Report

Merging #3439 (3447cbf) into master (b418f89) will increase coverage by 0.00%. The diff coverage is 0.00%.

@@            Coverage Diff            @@
##             master    #3439   +/-   ##
=========================================
  Coverage     51.92%   51.92%           
  Complexity       13       13           
=========================================
  Files           508      522   +14     
  Lines         29029    29049   +20     
  Branches       3985     3887   -98     
=========================================
+ Hits          15072    15084   +12     
- Misses        12532    12590   +58     
+ Partials       1425     1375   -50     
Impacted Files Coverage Δ
...ubi/engine/spark/operation/PlanOnlyStatement.scala 39.78% <0.00%> (-3.24%) :arrow_down:
...uubi/plugin/spark/authz/ranger/AccessRequest.scala 71.42% <0.00%> (-22.33%) :arrow_down:
...mon/src/main/scala/org/apache/kyuubi/Logging.scala 43.42% <0.00%> (-9.22%) :arrow_down:
.../main/scala/org/apache/kyuubi/util/SignUtils.scala 87.87% <0.00%> (-8.68%) :arrow_down:
.../kyuubi/operation/KyuubiApplicationOperation.scala 40.90% <0.00%> (-6.46%) :arrow_down:
.../kyuubi/server/mysql/constant/MySQLErrorCode.scala 13.84% <0.00%> (-6.16%) :arrow_down:
...pache/kyuubi/engine/YarnApplicationOperation.scala 58.73% <0.00%> (-4.24%) :arrow_down:
...apache/kyuubi/session/KyuubiBatchSessionImpl.scala 86.58% <0.00%> (-4.09%) :arrow_down:
...ache/kyuubi/server/mysql/MySQLCommandHandler.scala 77.77% <0.00%> (-4.05%) :arrow_down:
...uubi/plugin/spark/authz/util/SemanticVersion.scala 50.00% <0.00%> (-3.58%) :arrow_down:
... and 68 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov-commenter avatar Sep 13 '22 03:09 codecov-commenter

shall we remove this two? they are dangerous and not very useful

yaooqinn avatar Sep 13 '22 03:09 yaooqinn

SPARK-35378 add assertCommandExecuted since spark 3.2.0,spark 3.1 is normal. we can fix this case except execution mode in json style, can we just remove execution mode in json style?

lsm1 avatar Sep 13 '22 09:09 lsm1

ok

yaooqinn avatar Sep 14 '22 06:09 yaooqinn

this introduces unstable private class from spark, not a good solution to me

yaooqinn avatar Sep 14 '22 06:09 yaooqinn