kyuubi icon indicating copy to clipboard operation
kyuubi copied to clipboard

[SUBTASK] [KYUUBI #3420] Spark SQL Engine register zk with ui info

Open zwangsheng opened this issue 3 years ago • 2 comments

Why are the changes needed?

See more in #3420 This pr aim to improve spark sql engine register zookeeper with spark ui info

How was this patch tested?

  • [x] Add some test cases that check the changes thoroughly including negative and positive cases if possible

  • [ ] Add screenshots for manual tests if appropriate

  • [ ] Run test locally before make a pull request

zwangsheng avatar Sep 07 '22 08:09 zwangsheng

Codecov Report

Merging #3436 (be10a55) into master (c3c7707) will decrease coverage by 0.01%. The diff coverage is 90.47%.

:exclamation: Current head be10a55 differs from pull request most recent head 573e16d. Consider uploading reports for the commit 573e16d to get more accurate results

@@             Coverage Diff              @@
##             master    #3436      +/-   ##
============================================
- Coverage     51.69%   51.67%   -0.02%     
  Complexity       13       13              
============================================
  Files           482      482              
  Lines         26917    26949      +32     
  Branches       3758     3761       +3     
============================================
+ Hits          13914    13926      +12     
- Misses        11653    11667      +14     
- Partials       1350     1356       +6     
Impacted Files Coverage Δ
...ha/client/zookeeper/ZookeeperDiscoveryClient.scala 69.54% <83.33%> (+0.26%) :arrow_up:
...ubi/engine/spark/SparkTBinaryFrontendService.scala 81.92% <100.00%> (+0.22%) :arrow_up:
...in/scala/org/apache/kyuubi/config/KyuubiConf.scala 97.32% <100.00%> (-0.20%) :arrow_down:
...la/org/apache/kyuubi/service/FrontendService.scala 100.00% <100.00%> (ø)
.../org/apache/kyuubi/ha/client/ServiceNodeInfo.scala 88.88% <100.00%> (+1.38%) :arrow_up:
.../kyuubi/server/mysql/constant/MySQLErrorCode.scala 13.84% <0.00%> (-6.16%) :arrow_down:
...ache/kyuubi/server/mysql/MySQLCommandHandler.scala 75.00% <0.00%> (-4.55%) :arrow_down:
...apache/kyuubi/engine/JpsApplicationOperation.scala 77.41% <0.00%> (-3.23%) :arrow_down:
...ache/kyuubi/server/mysql/MySQLGenericPackets.scala 76.59% <0.00%> (-2.13%) :arrow_down:
...rg/apache/kyuubi/ctl/cmd/log/LogBatchCommand.scala 78.00% <0.00%> (-2.00%) :arrow_down:
... and 6 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov-commenter avatar Sep 15 '22 11:09 codecov-commenter

cc @pan3793 @yaooqinn

zwangsheng avatar Sep 16 '22 02:09 zwangsheng

Since another PR https://github.com/apache/incubator-kyuubi/pull/3684 completed part of its goal and was merged, this PR was closed and a new one was built later based on the existing master branch.

zwangsheng avatar Nov 04 '22 08:11 zwangsheng