kyuubi icon indicating copy to clipboard operation
kyuubi copied to clipboard

[KYUUBI #3285] [FEATURE] Add configs to post event async

Open zhaomin1423 opened this issue 3 years ago • 3 comments

Why are the changes needed?

close https://github.com/apache/incubator-kyuubi/issues/3285#issue-1345037289

How was this patch tested?

  • [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible

  • [ ] Add screenshots for manual tests if appropriate

  • [ ] Run test locally before make a pull request

zhaomin1423 avatar Aug 20 '22 06:08 zhaomin1423

cc @iodone @wForget

yaooqinn avatar Aug 24 '22 09:08 yaooqinn

@zhaomin1423 The EventBus implementation of asynchronous processing triggers a thread for each event and does not implement a consumer-production model with the event message queue, too many OperationEvent may lead to excessive thread resource usage. Have you tested the performance of EventBus asynchronous handler in a highly concurrent scenario?

iodone avatar Aug 24 '22 12:08 iodone

@zhaomin1423 The EventBus implementation of asynchronous processing triggers a thread for each event and does not implement a consumer-production model with the event message queue, too many OperationEvent may lead to excessive thread resource usage. Have you tested the performance of EventBus asynchronous handler in a highly concurrent scenario?

We can add a new async implementation that using consumer-production model later.

zhaomin1423 avatar Aug 25 '22 06:08 zhaomin1423

Thanks for the PR! This PR is being closed due to inactivity. This isn't a judgement on the merit of the PR in any way. If this is still an issue with the latest version of Kyuubi, please reopen it and ask a committer to remove the Stale tag!

Thank you for using Kyuubi!

github-actions[bot] avatar Dec 04 '22 00:12 github-actions[bot]

@zhaomin1423 do you have the opportunity to complete this feature before 1.7? or just postpone to 1.8

pan3793 avatar Feb 07 '23 06:02 pan3793