kyuubi icon indicating copy to clipboard operation
kyuubi copied to clipboard

[KYUUBI #3171] Expose mysql frontend connection metrics

Open lightning-L opened this issue 3 years ago • 1 comments

Why are the changes needed?

Close #3171

How was this patch tested?

  • [x] Add some test cases that check the changes thoroughly including negative and positive cases if possible

  • [ ] Add screenshots for manual tests if appropriate

  • [ ] Run test locally before make a pull request

lightning-L avatar Aug 15 '22 09:08 lightning-L

Codecov Report

Merging #3237 (9abcd39) into master (92f3a53) will decrease coverage by 0.28%. The diff coverage is 92.30%.

:exclamation: Current head 9abcd39 differs from pull request most recent head 2021752. Consider uploading reports for the commit 2021752 to get more accurate results

@@             Coverage Diff              @@
##             master    #3237      +/-   ##
============================================
- Coverage     51.23%   50.95%   -0.29%     
  Complexity       13       13              
============================================
  Files           468      470       +2     
  Lines         26145    26133      -12     
  Branches       3627     3611      -16     
============================================
- Hits          13396    13315      -81     
- Misses        11466    11546      +80     
+ Partials       1283     1272      -11     
Impacted Files Coverage Δ
...server/mysql/authentication/MySQLAuthHandler.scala 72.72% <0.00%> (ø)
...a/org/apache/kyuubi/metrics/MetricsConstants.scala 100.00% <100.00%> (ø)
...che/kyuubi/server/KyuubiMySQLFrontendService.scala 90.62% <100.00%> (+0.14%) :arrow_up:
...i/server/mysql/MySQLConnectionMetricsHandler.scala 100.00% <100.00%> (ø)
...mon/src/main/scala/org/apache/kyuubi/Logging.scala 43.42% <0.00%> (-1.32%) :arrow_down:
...yuubi/server/metadata/jdbc/JDBCMetadataStore.scala 89.27% <0.00%> (-0.70%) :arrow_down:
...ine/spark/operation/SparkSQLOperationManager.scala 83.33% <0.00%> (-0.28%) :arrow_down:
...he/kyuubi/jdbc/hive/ZooKeeperHiveClientHelper.java 3.00% <0.00%> (-0.20%) :arrow_down:
...rc/main/scala/org/apache/spark/ui/EnginePage.scala 78.86% <0.00%> (-0.07%) :arrow_down:
.../java/org/apache/kyuubi/jdbc/KyuubiHiveDriver.java 4.87% <0.00%> (ø)
... and 15 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov-commenter avatar Aug 18 '22 03:08 codecov-commenter

Thanks for the PR! This PR is being closed due to inactivity. This isn't a judgement on the merit of the PR in any way. If this is still an issue with the latest version of Kyuubi, please reopen it and ask a committer to remove the Stale tag!

Thank you for using Kyuubi!

github-actions[bot] avatar Nov 27 '22 00:11 github-actions[bot]