kyuubi icon indicating copy to clipboard operation
kyuubi copied to clipboard
verified publisher icon apache

[KYUUBI #3157][DOC] Modify logging doc due to using log4j2 instead of log4j

Open zwangsheng opened this issue 3 years ago • 3 comments

Why are the changes needed?

To close #3157

How was this patch tested?

  • [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible

  • [x] Add screenshots for manual tests if appropriate

  • [ ] Run test locally before make a pull request

zwangsheng avatar Aug 12 '22 09:08 zwangsheng

WX20220812-172402@2x

zwangsheng avatar Aug 12 '22 09:08 zwangsheng

CC @yaooqinn

zwangsheng avatar Aug 12 '22 09:08 zwangsheng

do we need a migration guide now? @pan3793 @turboFei @cfmcgrady

yaooqinn avatar Aug 12 '22 09:08 yaooqinn

Apache Log4j provides a migration guide, we can add the link to doc. https://logging.apache.org/log4j/2.x/manual/migration.html

pan3793 avatar Aug 12 '22 11:08 pan3793

Apache Log4j provides a migration guide, we can add the link to doc. https://logging.apache.org/log4j/2.x/manual/migration.html

I suggest we have our own guide to mention log4j's, we may have some other API change now and in the future

yaooqinn avatar Aug 12 '22 11:08 yaooqinn

Thanks, merging to master

pan3793 avatar Aug 15 '22 13:08 pan3793