kyuubi
kyuubi copied to clipboard
[KYUUBI #1776][FOLLOWUP] Fill empty td tag for `Failure Reason` column in EngineTable
Why are the changes needed?
Followup #1776
'Failure Reason' column needs to be filled with empty td tag when there is no exception:

How was this patch tested?
-
[ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible
-
[X] Add screenshots for manual tests if appropriate

-
[ ] Run test locally before make a pull request
cc @cfmcgrady
Codecov Report
Merging #3223 (a83d000) into master (6aa898e) will increase coverage by
0.07%. The diff coverage is78.57%.
@@ Coverage Diff @@
## master #3223 +/- ##
============================================
+ Coverage 51.56% 51.63% +0.07%
Complexity 6 6
============================================
Files 459 464 +5
Lines 25556 25652 +96
Branches 3545 3551 +6
============================================
+ Hits 13177 13245 +68
- Misses 11121 11141 +20
- Partials 1258 1266 +8
| Impacted Files | Coverage Δ | |
|---|---|---|
| ...rc/main/scala/org/apache/spark/ui/EnginePage.scala | 78.93% <50.00%> (+0.06%) |
:arrow_up: |
| ...rg/apache/kyuubi/events/EventHandlerRegister.scala | 60.00% <60.00%> (ø) |
|
| ...rg/apache/kyuubi/engine/spark/SparkSQLEngine.scala | 76.87% <100.00%> (-0.01%) |
:arrow_down: |
| ...ngine/spark/events/SparkEventHandlerRegister.scala | 100.00% <100.00%> (ø) |
|
| ...che/kyuubi/events/ServerEventHandlerRegister.scala | 100.00% <100.00%> (ø) |
|
| .../scala/org/apache/kyuubi/server/KyuubiServer.scala | 53.84% <100.00%> (-4.60%) |
:arrow_down: |
| ...ain/scala/org/apache/kyuubi/engine/EngineRef.scala | 74.07% <0.00%> (-2.12%) |
:arrow_down: |
| ...rg/apache/kyuubi/ctl/cmd/log/LogBatchCommand.scala | 78.00% <0.00%> (-2.00%) |
:arrow_down: |
| ...pache/kyuubi/engine/YarnApplicationOperation.scala | 64.81% <0.00%> (-1.86%) |
:arrow_down: |
| ...mon/src/main/scala/org/apache/kyuubi/Logging.scala | 43.42% <0.00%> (-1.32%) |
:arrow_down: |
| ... and 11 more |
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more
Thanks, merging to master