kyuubi icon indicating copy to clipboard operation
kyuubi copied to clipboard

[KYUUBI-3169][SUB-TASK] Expose rest rpc metrics

Open turboFei opened this issue 3 years ago • 8 comments

Code of Conduct

Search before asking

  • [X] I have searched in the issues and found no similar issues.

Describe the feature

Sub-task of #3169 Expose the metrics likes:

kyuubi.rest.connection.opend
kyuubi.rest.connection.failed
kyuubi.rest.connection.total
kyuubi.rest.connection.${method}.opened
kyuubi.rest.connection.${method}.failed
kyuubi.rest.connection.${method}.total

The method value could be one of the following: get, post, put, delete

Motivation

monitor the rest rpc

Describe the solution

No response

Additional context

No response

Are you willing to submit PR?

  • [ ] Yes I am willing to submit a PR!

turboFei avatar Jul 28 '22 01:07 turboFei

cc @yaooqinn

turboFei avatar Jul 28 '22 01:07 turboFei

only rest,how about the rest?

yaooqinn avatar Jul 28 '22 02:07 yaooqinn

kyuubi.rest.connection.opend

Do you mean kyuubi.rest.opend instead of kyuubi.rest.connection.opend?

turboFei avatar Jul 28 '22 02:07 turboFei

oh.. i mean only recording the REST frontends? what about the rest frontends

yaooqinn avatar Jul 28 '22 03:07 yaooqinn

The REST frontends seems special, because it is not interactive connection.

and now there is metrics(THRIFT_HTTP_CONN) for KyuubiTHttpFrontendService.

And there is no metrics for below frontends:

  • thrift binary
  • mysql
  • REST

The kyuubi.connection.opened is for all frontends.

turboFei avatar Jul 28 '22 03:07 turboFei

we need an umbrella then to support all of them, not just for rest, wdyt?

yaooqinn avatar Jul 28 '22 03:07 yaooqinn

we need an umbrella then to support all of them, not just for rest, wdyt?

Agree with that, will raise an umbrella ticket.

turboFei avatar Jul 28 '22 03:07 turboFei

we can also check apache/hive for referecnes

yaooqinn avatar Jul 28 '22 03:07 yaooqinn

Reference: https://github.com/apache/hive/blob/9ad5a0b28b136521ded27b4b5418f61b610da788/service/src/java/org/apache/hive/service/cli/thrift/ThriftHttpCLIService.java#L241 https://github.com/apache/hive/blob/7b3ecf617a6d46f48a3b6f77e0339fd4ad95a420/itests/hive-unit/src/test/java/org/apache/hive/jdbc/miniHS2/TestHs2ConnectionMetricsHttp.java

lightning-L avatar Aug 15 '22 09:08 lightning-L