kyuubi icon indicating copy to clipboard operation
kyuubi copied to clipboard

[KYUUBI #3138] [Subtask] DorisSQLEngine - Add jdbc engine to dist

Open zhaomin1423 opened this issue 3 years ago • 2 comments

Why are the changes needed?

close https://github.com/apache/incubator-kyuubi/issues/3138#issue-1316764571

How was this patch tested?

  • [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible

  • [ ] Add screenshots for manual tests if appropriate

  • [ ] Run test locally before make a pull request

zhaomin1423 avatar Jul 26 '22 11:07 zhaomin1423

Codecov Report

Merging #3146 (51e10b0) into master (5c1ea6e) will increase coverage by 0.22%. The diff coverage is n/a.

:exclamation: Current head 51e10b0 differs from pull request most recent head e6bba9e. Consider uploading reports for the commit e6bba9e to get more accurate results

@@             Coverage Diff              @@
##             master    #3146      +/-   ##
============================================
+ Coverage     51.33%   51.56%   +0.22%     
  Complexity        6        6              
============================================
  Files           458      463       +5     
  Lines         25388    25587     +199     
  Branches       3536     3548      +12     
============================================
+ Hits          13033    13193     +160     
- Misses        11116    11134      +18     
- Partials       1239     1260      +21     
Impacted Files Coverage Δ
...main/java/org/apache/kyuubi/jdbc/KyuubiDriver.java 0.00% <0.00%> (-100.00%) :arrow_down:
.../apache/kyuubi/client/api/v1/dto/BatchRequest.java 52.94% <0.00%> (-17.06%) :arrow_down:
...uthz/ranger/RuleApplyRowFilterAndDataMasking.scala 80.00% <0.00%> (-13.55%) :arrow_down:
...pache/kyuubi/engine/YarnApplicationOperation.scala 64.81% <0.00%> (-13.24%) :arrow_down:
...org/apache/kyuubi/ha/client/ServiceDiscovery.scala 83.33% <0.00%> (-12.50%) :arrow_down:
...rg/apache/kyuubi/engine/ApplicationOperation.scala 94.11% <0.00%> (-5.89%) :arrow_down:
...he/kyuubi/ha/client/etcd/EtcdDiscoveryClient.scala 67.50% <0.00%> (-4.92%) :arrow_down:
.../scala/org/apache/kyuubi/server/KyuubiServer.scala 53.84% <0.00%> (-4.60%) :arrow_down:
...g/apache/kyuubi/client/api/v1/dto/VersionInfo.java 53.84% <0.00%> (-4.49%) :arrow_down:
...apache/kyuubi/client/api/v1/dto/SessionHandle.java 53.84% <0.00%> (-4.49%) :arrow_down:
... and 84 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov-commenter avatar Aug 11 '22 10:08 codecov-commenter

Add all jars to /external/jdbc. @pan3793

zhaomin1423 avatar Aug 11 '22 10:08 zhaomin1423

Thanks, merging to master

pan3793 avatar Aug 15 '22 13:08 pan3793