kyuubi icon indicating copy to clipboard operation
kyuubi copied to clipboard

[KYUUBI #1265] `OPTIMIZE` where clause expression support

Open cfmcgrady opened this issue 2 years ago • 2 comments

Why are the changes needed?

to close #1265

After this PR, the following case will work

CREATE TABLE p (c1 INT, c2 INT, c3 INT) PARTITIONED BY (event_date DATE);
OPTIMIZE p where event_date = current_date() ZORDER BY c1, c2;

How was this patch tested?

  • [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible

  • [ ] Add screenshots for manual tests if appropriate

  • [x] Run test locally before make a pull request

cfmcgrady avatar Jun 16 '22 07:06 cfmcgrady

Codecov Report

Merging #2893 (97ac710) into master (a622c0a) will not change coverage. The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #2893   +/-   ##
======================================
  Coverage    0.00%   0.00%           
======================================
  Files         561     561           
  Lines       30953   30953           
  Branches     4063    4063           
======================================
  Misses      30953   30953           

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov-commenter avatar Jun 18 '22 08:06 codecov-commenter

The failed UT is irrelevant. Ready for review, please take another look when you have time. @ulysses-you

cfmcgrady avatar Jun 20 '22 05:06 cfmcgrady

cc @pan3793 @cxzl25

cfmcgrady avatar Jun 25 '23 03:06 cfmcgrady

looks fine, do we have end to end test ?

ulysses-you avatar Jun 25 '23 06:06 ulysses-you

looks fine, do we have end to end test ?

No, we only have the unit test OPTIMIZE command is parsed as expected now, the idea is derived from the Delta project, and I think it's OK to merge it first.

cfmcgrady avatar Jun 26 '23 02:06 cfmcgrady

thanks for the review, merging to master(v1.8.0).

cfmcgrady avatar Jul 05 '23 02:07 cfmcgrady