kyuubi icon indicating copy to clipboard operation
kyuubi copied to clipboard

[KYUUBI #2653] Init frontend framework

Open yanghua opened this issue 3 years ago • 10 comments

Why are the changes needed?

How was this patch tested?

  • [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible

  • [ ] Add screenshots for manual tests if appropriate

  • [ ] Run test locally before make a pull request

yanghua avatar Jun 09 '22 07:06 yanghua

Codecov Report

Merging #2840 (a06c982) into master (e3bf604) will decrease coverage by 1.59%. The diff coverage is 4.16%.

@@             Coverage Diff              @@
##             master    #2840      +/-   ##
============================================
- Coverage     64.26%   62.66%   -1.60%     
+ Complexity      215        6     -209     
============================================
  Files           517      421      -96     
  Lines         22850    20321    -2529     
  Branches       2964     2598     -366     
============================================
- Hits          14684    12734    -1950     
+ Misses         6774     6352     -422     
+ Partials       1392     1235     -157     
Impacted Files Coverage Δ
.../kyuubi/client/api/v1/dto/OverviewInformation.java 0.00% <0.00%> (ø)
...e/kyuubi/client/api/v1/dto/WebuiConfiguration.java 0.00% <0.00%> (ø)
...rg/apache/kyuubi/server/api/v1/WebuiResource.scala 0.00% <0.00%> (ø)
.../apache/kyuubi/server/api/v1/ApiRootResource.scala 85.00% <50.00%> (-3.89%) :arrow_down:
...ache/kyuubi/server/KyuubiRestFrontendService.scala 82.66% <100.00%> (-3.49%) :arrow_down:
...e/kyuubi/server/api/v1/KyuubiOpenApiResource.scala 83.78% <100.00%> (ø)
...la/org/apache/kyuubi/operation/FetchIterator.scala 69.76% <0.00%> (-23.26%) :arrow_down:
.../apache/kyuubi/server/api/v1/BatchesResource.scala 73.21% <0.00%> (-13.15%) :arrow_down:
...apache/kyuubi/engine/hive/HiveProcessBuilder.scala 72.88% <0.00%> (-13.09%) :arrow_down:
...rg/apache/kyuubi/ctl/cmd/log/LogBatchCommand.scala 80.00% <0.00%> (-12.86%) :arrow_down:
... and 153 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e3bf604...a06c982. Read the comment docs.

codecov-commenter avatar Jun 09 '22 10:06 codecov-commenter

kyuubi-server/src/main/resources/org/apache/kyuubi/ui/static/icon.min.css truncated not deleted?

yaooqinn avatar Jun 09 '22 11:06 yaooqinn

Encounter the following exception when I'm trying to start Kyuubi Server w/ REST FE.

Exception in thread "main" org.apache.kyuubi.KyuubiException: Failed to Start KyuubiServer
	at org.apache.kyuubi.service.CompositeService.$anonfun$start$1(CompositeService.scala:52)
	at org.apache.kyuubi.service.CompositeService.$anonfun$start$1$adapted(CompositeService.scala:45)
	at scala.collection.mutable.ResizableArray.foreach(ResizableArray.scala:62)
	at scala.collection.mutable.ResizableArray.foreach$(ResizableArray.scala:55)
	at scala.collection.mutable.ArrayBuffer.foreach(ArrayBuffer.scala:49)
	at org.apache.kyuubi.service.CompositeService.start(CompositeService.scala:45)
	at org.apache.kyuubi.service.Serverable.start(Serverable.scala:51)
	at org.apache.kyuubi.server.KyuubiServer.start(KyuubiServer.scala:144)
	at org.apache.kyuubi.server.KyuubiServer$.startServer(KyuubiServer.scala:68)
	at org.apache.kyuubi.server.KyuubiServer$.main(KyuubiServer.scala:97)
	at org.apache.kyuubi.server.KyuubiServer.main(KyuubiServer.scala)
Caused by: org.apache.kyuubi.KyuubiException: Cannot start KyuubiRestFrontendService
	at org.apache.kyuubi.server.KyuubiRestFrontendService.start(KyuubiRestFrontendService.scala:128)
	at org.apache.kyuubi.service.CompositeService.$anonfun$start$1(CompositeService.scala:47)
	... 10 more
Caused by: org.apache.kyuubi.KyuubiException: Could not find resource path for Web UI: web
	at org.apache.kyuubi.server.ui.JettyUtils$.createStaticHandler(JettyUtils.scala:45)
	at org.apache.kyuubi.server.ui.JettyServer.addStaticHandler(JettyServer.scala:62)
	at org.apache.kyuubi.server.KyuubiRestFrontendService.startInternal(KyuubiRestFrontendService.scala:74)
	at org.apache.kyuubi.server.KyuubiRestFrontendService.start(KyuubiRestFrontendService.scala:126)
	... 11 more

pan3793 avatar Jun 16 '22 18:06 pan3793

@pan3793

Did you run:

npm run build

before generating the binary package?

yanghua avatar Jun 17 '22 02:06 yanghua

The first-round review is about building and code style, and how can we handle the license for frontend components and dependencies? I'm starting to look and learn the code now.

pan3793 avatar Jun 21 '22 15:06 pan3793

@pan3793: Any ETA on this PR will get merged to master? Thanks.

mmuru avatar Aug 02 '22 23:08 mmuru

Plan to get in master after cutting branch-1.6 because of the lack of frontend developers/reviewers.

pan3793 avatar Aug 03 '22 01:08 pan3793

@tongwl Are you interested in joining us to build the Kyuubi Web UI together?

yanghua avatar Aug 10 '22 10:08 yanghua

@tongwl Are you interested in joining us to build the Kyuubi Web UI together?

Hi @yanghua, sure. My team is also using kyuubi, we are interested in in contributing to Kyuubi :)

tongwl avatar Aug 11 '22 02:08 tongwl

@tongwl Are you interested in joining us to build the Kyuubi Web UI together?

Hi @yanghua, sure. My team is also using kyuubi, we are interested in in contributing to Kyuubi :)

Hi @tongwl, can you leave a comment at https://github.com/apache/incubator-kyuubi/discussions/925, so we can add you in our official website

yaooqinn avatar Aug 11 '22 02:08 yaooqinn

Close and in favor #3250

pan3793 avatar Sep 07 '22 12:09 pan3793