kylin icon indicating copy to clipboard operation
kylin copied to clipboard

Test if this patch pass CI?

Open hit-lacus opened this issue 2 years ago • 2 comments

Proposed changes

Test if this patch pass CI?

Github Branch

As most of the development works are on Kylin 4, we need to switch it as main branch. Apache Kylin community changes the branch settings on Github since 2021-08-04 :

  1. The default branch main is for Kylin 4.x (Parquet storage);
  2. The original branch master for Kylin 3.x (HBase storage) has been renamed to kylin3 ;

Please check Intro to Kylin 4 architecture and INFRA-22166 if you are interested.

Types of changes

What types of changes does your code introduce to Kylin? Put an x in the boxes that apply

  • [ ] Bugfix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [ ] Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • [ ] I have create an issue on Kylin's jira, and have described the bug/feature there in detail
  • [ ] Commit messages in my PR start with the related jira ID, like "KYLIN-0000 Make Kylin project open-source"
  • [ ] Compiling and unit tests pass locally with my changes
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [ ] I have added necessary documentation (if appropriate)
  • [ ] Any dependent changes have been merged

Further comments

If this is a relatively large or complex change, kick off the discussion at [email protected] or [email protected] by explaining why you chose the solution you did and what alternatives you considered, etc...

hit-lacus avatar Aug 14 '22 23:08 hit-lacus

This pull request fixes 1 alert when merging 83b7ebbe2057b3a3a8eb6f9dfee4cc47e0d33c0d into 9e28c8732a0bf50290584dc047fe48b73890bcae - view on LGTM.com

fixed alerts:

  • 1 for `TrustManager` that accepts all certificates

lgtm-com[bot] avatar Aug 15 '22 00:08 lgtm-com[bot]

This pull request fixes 1 alert when merging cd21918bf4784955ddce39e856fa27d45e941045 into 9e28c8732a0bf50290584dc047fe48b73890bcae - view on LGTM.com

fixed alerts:

  • 1 for `TrustManager` that accepts all certificates

lgtm-com[bot] avatar Aug 15 '22 02:08 lgtm-com[bot]

This pull request fixes 1 alert when merging cb7f7a0ba6e5e3155436713fe5ef31d6fed88d06 into 9e28c8732a0bf50290584dc047fe48b73890bcae - view on LGTM.com

fixed alerts:

  • 1 for `TrustManager` that accepts all certificates

lgtm-com[bot] avatar Aug 26 '22 06:08 lgtm-com[bot]