kylin icon indicating copy to clipboard operation
kylin copied to clipboard

KYLIN-5200, support raw measure

Open liuzhao-lz opened this issue 2 years ago • 1 comments

Proposed changes

Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.

Github Branch

As most of the development works are on Kylin 4, we need to switch it as main branch. Apache Kylin community changes the branch settings on Github since 2021-08-04 :

  1. The default branch main is for Kylin 4.x (Parquet storage);
  2. The original branch master for Kylin 3.x (HBase storage) has been renamed to kylin3 ;

Please check Intro to Kylin 4 architecture and INFRA-22166 if you are interested.

Types of changes

What types of changes does your code introduce to Kylin? Put an x in the boxes that apply

  • [ ] Bugfix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [ ] Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • [ ] I have create an issue on Kylin's jira, and have described the bug/feature there in detail
  • [ ] Commit messages in my PR start with the related jira ID, like "KYLIN-0000 Make Kylin project open-source"
  • [ ] Compiling and unit tests pass locally with my changes
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [ ] I have added necessary documentation (if appropriate)
  • [ ] Any dependent changes have been merged

Further comments

If this is a relatively large or complex change, kick off the discussion at [email protected] or [email protected] by explaining why you chose the solution you did and what alternatives you considered, etc...

liuzhao-lz avatar Jun 24 '22 08:06 liuzhao-lz

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@66e83b4). Click here to learn what that means. The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1896   +/-   ##
=======================================
  Coverage        ?   23.50%           
  Complexity      ?     4463           
=======================================
  Files           ?     1145           
  Lines           ?    65381           
  Branches        ?     9342           
=======================================
  Hits            ?    15365           
  Misses          ?    48397           
  Partials        ?     1619           

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 66e83b4...2186749. Read the comment docs.

codecov-commenter avatar Jun 30 '22 08:06 codecov-commenter

Wrong understanding of raw measure

liuzhao-lz avatar Oct 11 '22 12:10 liuzhao-lz