kylin icon indicating copy to clipboard operation
kylin copied to clipboard

update find-xx-dependency.sh for macOS compatibility

Open Kyofin opened this issue 4 years ago • 6 comments

Proposed changes

fix bug when start kylin in macOS

Types of changes

  • update find jars command for macOS compatibility

Kyofin avatar Dec 18 '20 01:12 Kyofin

Codecov Report

Merging #1515 (03b1fe5) into master (930daaf) will decrease coverage by 0.01%. The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1515      +/-   ##
============================================
- Coverage     25.50%   25.49%   -0.02%     
+ Complexity     6764     6759       -5     
============================================
  Files          1505     1505              
  Lines         93628    93628              
  Branches      13115    13115              
============================================
- Hits          23882    23867      -15     
- Misses        67369    67377       +8     
- Partials       2377     2384       +7     
Impacted Files Coverage Δ Complexity Δ
.../apache/kylin/tool/query/ProbabilityGenerator.java 65.78% <0.00%> (-10.53%) 10.00% <0.00%> (-1.00%)
...he/kylin/dict/lookup/cache/RocksDBLookupTable.java 72.97% <0.00%> (-5.41%) 6.00% <0.00%> (-1.00%)
...ream/core/storage/columnar/ColumnarStoreCache.java 50.00% <0.00%> (-2.28%) 7.00% <0.00%> (-1.00%)
...va/org/apache/kylin/tool/query/QueryGenerator.java 78.88% <0.00%> (-2.23%) 22.00% <0.00%> (-2.00%)
...rg/apache/kylin/cube/inmemcubing/MemDiskStore.java 69.60% <0.00%> (-1.52%) 7.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 930daaf...03b1fe5. Read the comment docs.

codecov-io avatar Dec 18 '20 02:12 codecov-io

Pull Request Test Coverage Report for Build 6661

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 2 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.002%) to 28.042%

Files with Coverage Reduction New Missed Lines %
core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/MemDiskStore.java 1 78.12%
tool/src/main/java/org/apache/kylin/tool/query/ProbabilityGenerator.java 1 78.95%
<!-- Total: 2
Totals Coverage Status
Change from base Build 6652: -0.002%
Covered Lines: 26255
Relevant Lines: 93628

💛 - Coveralls

coveralls avatar Dec 18 '20 02:12 coveralls

As far as I know, Mac OS is not the OS which Kylin going to support. And I am not really ensure this patch is compatible with current supported os (linux distribution) .

hit-lacus avatar Dec 29 '20 02:12 hit-lacus

Hi Kang, are you running Kylin service on MacOS?

shaofengshi avatar Dec 31 '20 02:12 shaofengshi

Hi Kang, are you running Kylin service on MacOS?

Yes,I run kylin In MacOS through change the scripts i commit.Because i want to test kylin in my develop Env. The log is below.

2021-03-13 11:20:27,922 INFO  [close-hbase-conn] zookeeper.ZooKeeper:684 : Session: 0x1782997e01d0008 closed
2021-03-13 11:20:27,922 INFO  [main-EventThread] zookeeper.ClientCnxn:524 : EventThread shut down
2021-03-13 11:20:27,932 INFO  [close-hbase-conn] client.ConnectionManager$HConnectionImplementation:2300 : Closing master protocol: MasterService
2021-03-13 11:20:27,932 INFO  [close-hbase-conn] client.ConnectionManager$HConnectionImplementation:1850 : Closing zookeeper sessionid=0x1782997e01d0007
2021-03-13 11:20:27,933 INFO  [close-hbase-conn] zookeeper.ZooKeeper:684 : Session: 0x1782997e01d0007 closed
2021-03-13 11:20:27,933 INFO  [main-EventThread] zookeeper.ClientCnxn:524 : EventThread shut down

A new Kylin instance is started by huzekang. To stop it, run 'kylin.sh stop'
Check the log at /Users/huzekang/cdh5.16/apache-kylin-3.1.1-bin-cdh57/logs/kylin.log
Web UI is at http://huzekangdeMacBook-Pro.local:7070/kylin
------------------------------------------------------------
~/cdh5.16/apache-kylin-3.1.1-bin-cdh57 »

image

Kyofin avatar Mar 13 '21 03:03 Kyofin