kylin icon indicating copy to clipboard operation
kylin copied to clipboard

KYLIN-4788 add segmentName and regionName in Coprocessor deadline info

Open fengpod opened this issue 4 years ago • 5 comments

Proposed changes

Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.

Types of changes

What types of changes does your code introduce to Kylin? Put an x in the boxes that apply

  • [ ] Bugfix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [ ] Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • [x] I have create an issue on Kylin's jira, and have described the bug/feature there in detail
  • [x] Commit messages in my PR start with the related jira ID, like "KYLIN-0000 Make Kylin project open-source"
  • [ ] Compiling and unit tests pass locally with my changes
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [ ] If this change need a document change, I will prepare another pr against the document branch
  • [ ] Any dependent changes have been merged

Further comments

If this is a relatively large or complex change, kick off the discussion at user@kylin or dev@kylin by explaining why you chose the solution you did and what alternatives you considered, etc...

fengpod avatar Oct 15 '20 02:10 fengpod

Add segmentName and regionName to Coprocessor deadline exception info,for locating the cube and region exactly。 When Coprocessor throws dealline expcetion,the info will looks like this: image

fengpod avatar Oct 15 '20 02:10 fengpod

good job,+1 @xiaowangyu

bigxiaochu avatar Oct 20 '20 05:10 bigxiaochu

Thank you for @fengpod 's patch and @bigxiaochu 's comment, I will verify and merge this patch.

hit-lacus avatar Oct 22 '20 08:10 hit-lacus

Hi @fengpod , we know that apache project provide a version convention of MAJOR.MINOR.PATCH, and this patch require user to manually upgrade coprocessor, we think it is suitable for release in next MINOR or MAJOR version.

We suggest to move release of this patch into next minor version (3.2.0), so we won't merge it right now.

hit-lacus avatar Nov 16 '20 04:11 hit-lacus