kylin icon indicating copy to clipboard operation
kylin copied to clipboard

KYLIN-4717 Failed to build webapp

Open guangxuCheng opened this issue 4 years ago • 4 comments

Proposed changes

Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.

Types of changes

What types of changes does your code introduce to Kylin? Put an x in the boxes that apply

  • [x] Bugfix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [ ] Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • [x] I have create an issue on Kylin's jira, and have described the bug/feature there in detail
  • [x] Commit messages in my PR start with the related jira ID, like "KYLIN-0000 Make Kylin project open-source"
  • [x] Compiling and unit tests pass locally with my changes
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [ ] If this change need a document change, I will prepare another pr against the document branch
  • [ ] Any dependent changes have been merged

Further comments

If this is a relatively large or complex change, kick off the discussion at user@kylin or dev@kylin by explaining why you chose the solution you did and what alternatives you considered, etc...

guangxuCheng avatar Aug 25 '20 03:08 guangxuCheng

Pull Request Test Coverage Report for Build 6284

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 4 unchanged lines in 3 files lost coverage.
  • Overall coverage increased (+0.01%) to 28.067%

Files with Coverage Reduction New Missed Lines %
core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/MemDiskStore.java 1 78.12%
tool/src/main/java/org/apache/kylin/tool/query/ProbabilityGenerator.java 1 81.58%
stream-core/src/main/java/org/apache/kylin/stream/core/storage/columnar/ColumnarStoreCache.java 2 57.95%
<!-- Total: 4
Totals Coverage Status
Change from base Build 6276: 0.01%
Covered Lines: 26253
Relevant Lines: 93538

💛 - Coveralls

coveralls avatar Aug 25 '20 04:08 coveralls

@zzcclp Please help to review this.

hit-lacus avatar Sep 15 '20 02:09 hit-lacus

The root cause of this issue you met is that the version of node and npm is higher than required, the required version is below: node: lower than v10.20.X npm: lower than 6.14.X you can use nvm to install node and npm, which supports to switch node version you need.

So in my opinion it don't need to fix this issue.

zzcclp avatar Sep 15 '20 04:09 zzcclp

`✖ 4 of 3 tests failed:

  1. jpegtran should return path to jpegtran binary: AssertionError [ERR_ASSERTION]: The expression evaluated to a falsy value:

assert(stderr.toString().indexOf('libjpeg-turbo') !== -1)

  at /Users/cheng/IdeaProjects/tdw-kylin/webapp/node_modules/jpegtran-bin/test/test-jpegtran-path.js:18:4
  at ChildProcess.exithandler (child_process.js:301:5)
  at ChildProcess.emit (events.js:198:13)
  at maybeClose (internal/child_process.js:982:16)
  at Socket.stream.socket.on (internal/child_process.js:389:11)
  at Socket.emit (events.js:198:13)
  at Pipe._handle.close (net.js:607:12)
  1. jpegtran should successfully proxy jpegtran: AssertionError [ERR_ASSERTION]: The expression evaluated to a falsy value:

assert(stderr.toString().indexOf('libjpeg-turbo') !== -1)

  at /Users/cheng/IdeaProjects/tdw-kylin/webapp/node_modules/jpegtran-bin/test/test-jpegtran-path.js:27:4
  at ChildProcess.exithandler (child_process.js:301:5)
  at ChildProcess.emit (events.js:198:13)
  at maybeClose (internal/child_process.js:982:16)
  at Process.ChildProcess._handle.onexit (internal/child_process.js:259:5)
  1. jpegtran should minify a .jpg: Error: ENOENT: no such file or directory, stat 'test/minified.jpg' at Object.statSync (fs.js:855:3) at /Users/cheng/IdeaProjects/tdw-kylin/webapp/node_modules/jpegtran-bin/test/test-jpegtran-path.js:42:20 at ChildProcess.exithandler (child_process.js:301:5) at ChildProcess.emit (events.js:198:13) at maybeClose (internal/child_process.js:982:16) at Process.ChildProcess._handle.onexit (internal/child_process.js:259:5)

  2. jpegtran "after all" hook: Error: ENOENT: no such file or directory, unlink 'test/minified.jpg' at Object.unlinkSync (fs.js:956:3) at Context. (/Users/cheng/IdeaProjects/tdw-kylin/webapp/node_modules/jpegtran-bin/test/test-jpegtran-path.j s:11:6) at Hook.Runnable.run (/Users/cheng/IdeaProjects/tdw-kylin/webapp/node_modules/mocha/lib/runnable.js:213:32) at next (/Users/cheng/IdeaProjects/tdw-kylin/webapp/node_modules/mocha/lib/runner.js:243:10) at Immediate._onImmediate (/Users/cheng/IdeaProjects/tdw-kylin/webapp/node_modules/mocha/lib/runner.js:254:5) at runCallback (timers.js:705:18) at tryOnImmediate (timers.js:676:5) at processImmediate (timers.js:658:5)

pre-build test failed, compiling from source... Fetching http://downloads.sourceforge.net/project/libjpeg-turbo/1.2.90%20%281.3beta1%29/libjpeg-turbo-1.2.90.tar.gz... _http_client.js:116 throw new ERR_UNESCAPED_CHARACTERS('Request path'); ^

TypeError [ERR_UNESCAPED_CHARACTERS]: Request path contains unescaped characters at new ClientRequest (_http_client.js:116:13) at TunnelingAgent.request (http.js:42:10) at TunnelingAgent.createSocket (/Users/cheng/IdeaProjects/tdw-kylin/webapp/node_modules/jpegtran-bin/node_modules/tunnel-agent/index.js:117:25) at TunnelingAgent.createSecureSocket [as createSocket] (/Users/cheng/IdeaProjects/tdw-kylin/webapp/node_modules/jpegtran-bin/node_modules/tunnel-agent/index.js:184:41) at TunnelingAgent.addRequest (/Users/cheng/IdeaProjects/tdw-kylin/webapp/node_modules/jpegtran-bin/node_modules/tunnel-agent/index.js:80:8) at new ClientRequest (_http_client.js:258:16) at Object.request (https.js:289:10) at Request.start (/Users/cheng/IdeaProjects/tdw-kylin/webapp/node_modules/jpegtran-bin/node_modules/request/index.js:582:30) at Request.end (/Users/cheng/IdeaProjects/tdw-kylin/webapp/node_modules/jpegtran-bin/node_modules/request/index.js:1149:28) at /Users/cheng/IdeaProjects/tdw-kylin/webapp/node_modules/jpegtran-bin/node_modules/request/index.js:425:12 `

node version: 10.20.0 npm version: 6.14.4

Hi @zzcclp, I use node version 10.20.0, another error will be thrown, as shown above. The PR can also solve this exception

guangxuCheng avatar Sep 16 '20 03:09 guangxuCheng