kylin icon indicating copy to clipboard operation
kylin copied to clipboard

KYLIN-4440: IllegalStateException thrown when a query contains group …

Open jshmchenxi opened this issue 4 years ago • 2 comments

…by clause with case when of dimensional table columns

Proposed changes

Fix bug: IllegalStateException thrown when a query contains group by clause with case when of dimensional table columns

Types of changes

What types of changes does your code introduce to Kylin? Put an x in the boxes that apply

  • [x] Bugfix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [ ] Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • [x] I have create an issue on Kylin's jira, and have described the bug/feature there in detail
  • [x] Commit messages in my PR start with the related jira ID, like "KYLIN-0000 Make Kylin project open-source"
  • [ ] Compiling and unit tests pass locally with my changes
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [ ] If this change need a document change, I will prepare another pr against the document branch
  • [ ] Any dependent changes have been merged

Further comments

If this is a relatively large or complex change, kick off the discussion at user@kylin or dev@kylin by explaining why you chose the solution you did and what alternatives you considered, etc...

jshmchenxi avatar Apr 09 '20 12:04 jshmchenxi

Codecov Report

Merging #1174 into master will decrease coverage by 0.01%. The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1174      +/-   ##
============================================
- Coverage     25.02%   25.01%   -0.02%     
+ Complexity     6254     6252       -2     
============================================
  Files          1449     1449              
  Lines         88499    88499              
  Branches      12373    12373              
============================================
- Hits          22148    22138      -10     
- Misses        64177    64184       +7     
- Partials       2174     2177       +3     
Impacted Files Coverage Δ Complexity Δ
...va/org/apache/kylin/query/relnode/OLAPJoinRel.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...ream/core/storage/columnar/ColumnarStoreCache.java 50.00% <0.00%> (-5.69%) 7.00% <0.00%> (-1.00%)
...org/apache/kylin/rest/util/QueryRequestLimits.java 35.71% <0.00%> (-4.77%) 5.00% <0.00%> (-1.00%)
...rg/apache/kylin/cube/inmemcubing/MemDiskStore.java 70.21% <0.00%> (-0.92%) 7.00% <0.00%> (ø%)
...pache/kylin/job/impl/curator/CuratorScheduler.java 64.40% <0.00%> (-0.85%) 7.00% <0.00%> (ø%)
...ain/java/org/apache/kylin/dict/TrieDictionary.java 72.55% <0.00%> (-0.47%) 56.00% <0.00%> (-1.00%)
...core/storage/columnar/GeneralColumnDataReader.java 94.73% <0.00%> (+5.26%) 7.00% <0.00%> (+1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 6745acb...aa4ca54. Read the comment docs.

codecov-io avatar Apr 09 '20 12:04 codecov-io

Pull Request Test Coverage Report for Build 5817

  • 0 of 1 (0.0%) changed or added relevant line in 1 file are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.001%) to 27.478%

Changes Missing Coverage Covered Lines Changed/Added Lines %
query/src/main/java/org/apache/kylin/query/relnode/OLAPJoinRel.java 0 1 0.0%
<!-- Total: 0 1
Files with Coverage Reduction New Missed Lines %
stream-core/src/main/java/org/apache/kylin/stream/core/storage/columnar/ColumnarStoreCache.java 3 56.82%
<!-- Total: 3
Totals Coverage Status
Change from base Build 5800: -0.001%
Covered Lines: 24318
Relevant Lines: 88499

💛 - Coveralls

coveralls avatar Apr 09 '20 12:04 coveralls