kylin icon indicating copy to clipboard operation
kylin copied to clipboard

KYLIN-4227: add segment build callback

Open zhoukangcn opened this issue 6 years ago • 5 comments

see: https://issues.apache.org/jira/browse/KYLIN-4227

zhoukangcn avatar Dec 19 '19 07:12 zhoukangcn

Can one of the admins verify this patch?

asf-ci avatar Dec 19 '19 07:12 asf-ci

Can one of the admins verify this patch?

asf-ci avatar Dec 19 '19 07:12 asf-ci

Codecov Report

Merging #1008 into master will decrease coverage by 0.01%. The diff coverage is 8.88%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1008      +/-   ##
============================================
- Coverage      25.5%   25.49%   -0.02%     
- Complexity     6177     6179       +2     
============================================
  Files          1416     1416              
  Lines         85967    86012      +45     
  Branches      12059    12062       +3     
============================================
- Hits          21927    21925       -2     
- Misses        61902    61947      +45     
- Partials       2138     2140       +2
Impacted Files Coverage Δ Complexity Δ
...ain/java/org/apache/kylin/engine/mr/CubingJob.java 1.59% <0%> (-0.27%) 2 <0> (ø)
...ava/org/apache/kylin/rest/service/CubeService.java 0% <0%> (ø) 0 <0> (ø) :arrow_down:
...g/apache/kylin/rest/controller/CubeController.java 0% <0%> (ø) 0 <0> (ø) :arrow_down:
...ain/java/org/apache/kylin/cube/model/CubeDesc.java 64.31% <100%> (+0.18%) 183 <2> (+2) :arrow_up:
.../apache/kylin/cube/cuboid/TreeCuboidScheduler.java 63.84% <0%> (-2.31%) 0% <0%> (ø)
...rg/apache/kylin/cube/inmemcubing/MemDiskStore.java 69.3% <0%> (-0.92%) 7% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 27df350...d2e1c98. Read the comment docs.

codecov-io avatar Dec 19 '19 08:12 codecov-io

Pull Request Test Coverage Report for Build 5406

  • 4 of 45 (8.89%) changed or added relevant lines in 4 files are covered.
  • 8 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.01%) to 27.982%

Changes Missing Coverage Covered Lines Changed/Added Lines %
server-base/src/main/java/org/apache/kylin/rest/service/CubeService.java 0 5 0.0%
server-base/src/main/java/org/apache/kylin/rest/controller/CubeController.java 0 9 0.0%
engine-mr/src/main/java/org/apache/kylin/engine/mr/CubingJob.java 0 27 0.0%
<!-- Total: 4 45
Files with Coverage Reduction New Missed Lines %
engine-mr/src/main/java/org/apache/kylin/engine/mr/CubingJob.java 1 1.6%
core-cube/src/main/java/org/apache/kylin/cube/cuboid/TreeCuboidScheduler.java 2 68.46%
core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/MemDiskStore.java 5 77.81%
<!-- Total: 8
Totals Coverage Status
Change from base Build 5401: -0.01%
Covered Lines: 24068
Relevant Lines: 86012

💛 - Coveralls

coveralls avatar Dec 19 '19 08:12 coveralls

@nichunen Could you help to review this? Thank you

zhoukangcn avatar Jan 06 '20 02:01 zhoukangcn