kylin
kylin copied to clipboard
KYLIN-4227: add segment build callback
see: https://issues.apache.org/jira/browse/KYLIN-4227
Can one of the admins verify this patch?
Can one of the admins verify this patch?
Codecov Report
Merging #1008 into master will decrease coverage by
0.01%. The diff coverage is8.88%.
@@ Coverage Diff @@
## master #1008 +/- ##
============================================
- Coverage 25.5% 25.49% -0.02%
- Complexity 6177 6179 +2
============================================
Files 1416 1416
Lines 85967 86012 +45
Branches 12059 12062 +3
============================================
- Hits 21927 21925 -2
- Misses 61902 61947 +45
- Partials 2138 2140 +2
| Impacted Files | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| ...ain/java/org/apache/kylin/engine/mr/CubingJob.java | 1.59% <0%> (-0.27%) |
2 <0> (ø) |
|
| ...ava/org/apache/kylin/rest/service/CubeService.java | 0% <0%> (ø) |
0 <0> (ø) |
:arrow_down: |
| ...g/apache/kylin/rest/controller/CubeController.java | 0% <0%> (ø) |
0 <0> (ø) |
:arrow_down: |
| ...ain/java/org/apache/kylin/cube/model/CubeDesc.java | 64.31% <100%> (+0.18%) |
183 <2> (+2) |
:arrow_up: |
| .../apache/kylin/cube/cuboid/TreeCuboidScheduler.java | 63.84% <0%> (-2.31%) |
0% <0%> (ø) |
|
| ...rg/apache/kylin/cube/inmemcubing/MemDiskStore.java | 69.3% <0%> (-0.92%) |
7% <0%> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update 27df350...d2e1c98. Read the comment docs.
Pull Request Test Coverage Report for Build 5406
- 4 of 45 (8.89%) changed or added relevant lines in 4 files are covered.
- 8 unchanged lines in 3 files lost coverage.
- Overall coverage decreased (-0.01%) to 27.982%
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
|---|---|---|---|
| server-base/src/main/java/org/apache/kylin/rest/service/CubeService.java | 0 | 5 | 0.0% |
| server-base/src/main/java/org/apache/kylin/rest/controller/CubeController.java | 0 | 9 | 0.0% |
| engine-mr/src/main/java/org/apache/kylin/engine/mr/CubingJob.java | 0 | 27 | 0.0% |
| <!-- | Total: | 4 | 45 |
| Files with Coverage Reduction | New Missed Lines | % |
|---|---|---|
| engine-mr/src/main/java/org/apache/kylin/engine/mr/CubingJob.java | 1 | 1.6% |
| core-cube/src/main/java/org/apache/kylin/cube/cuboid/TreeCuboidScheduler.java | 2 | 68.46% |
| core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/MemDiskStore.java | 5 | 77.81% |
| <!-- | Total: | 8 |
| Totals | |
|---|---|
| Change from base Build 5401: | -0.01% |
| Covered Lines: | 24068 |
| Relevant Lines: | 86012 |
💛 - Coveralls
@nichunen Could you help to review this? Thank you