Customize prefix extractor for subkey
Customize prefix extractor for subkey. Range query prefermance is likely improved when applying this prefix extractor to subkey column family. It is more effective than FixedPrefixTransform and CappedPrefixTransform provided by Rocksdb. https://github.com/apache/incubator-kvrocks/pull/508 shows usage of prefix extractor.
Cool!How much performance improvement did you get from testing?
l did an incomplete test. For 1 millon times short range query, the query time is reduced more than 20%.
@shangxiaoxiong I didn't see where's using this prefix extractor.
https://github.com/apache/incubator-kvrocks/pull/508 shows the usage of prefix extractor (FixedPrefixTransform provided by Rocksdb) @git-hulk.
@shangxiaoxiong So I think we can merge what #508 does into this PR and use the new prefix extractor.
@shangxiaoxiong So I think we can merge what #508 does into this PR and use the new prefix extractor.
l think so and l can merge https://github.com/apache/incubator-kvrocks/pull/508 if there is no problem about the new prefix extractor.
Got it, thanks a lot.
Thank you for your contribution, it would be better if you could explain it in detail in this PR, which can help us to see the code and understand the design.
Thank you for your contribution, it would be better if you could explain it in detail in this PR, which can help us to see the code and understand the design.
Don't make me hammer you.
@caipengbo is right, we can add more informations to make this easier to review.
@caipengbo is right, we can add more informations to make this easier to review.
ha ha ha ! On the way.
@shangxiaoxiong You can help to pull the @ShooterIT's PR into this, then we can pull others to have a look again.
@shangxiaoxiong You can help to pull the @ShooterIT's PR into this, then we can pull others to have a look again.
OK
Hi @shangxiaoxiong! Any progress on this pull request?
Hi @shangxiaoxiong , do you still have time to continue this PR?
@PragmaTwice I will continue working on this and also #508 recently if @shangxiaoxiong and @ShooterIT don't have time to move on.
I will raise another PR to do this.