kvrocks icon indicating copy to clipboard operation
kvrocks copied to clipboard

Add redis-benchmark to CI

Open PragmaTwice opened this issue 3 years ago • 4 comments

Search before asking

  • [X] I had searched in the issues and found no similar issues.

Motivation

We can design a phase in CI (triggerred by PR or daily) to automatically run redis-benchmark to test the stability and performance of kvrocks under a certain commit, and report it while an evident performance downgrade or crash occurs in the benchmark phase.

Solution

No response

Are you willing to submit a PR?

  • [ ] I'm willing to submit a PR!

PragmaTwice avatar Sep 18 '22 08:09 PragmaTwice

I thinked about this feature. Very cool, we need this tests.

IMHO, we can add to x.py file something like this:

./x.py benchmark --bench-path=

with default value of client/request etc.

In CI script, we change step "Install redis" and copy redis-benchmark into $HOME/local/bin/.

Then we use -q options and run benchmark in quite format, just output req/sec.

In a first stage this numbers only for view, but maybe we can store a some historical tests results into file and after bench are running, check deviations.

So, I'am not a excellent C/Python/CI dev, but I can try to realize this step-by-step

aleksraiden avatar Oct 02 '22 11:10 aleksraiden

Thanks for your interest, please go ahead!

PragmaTwice avatar Oct 02 '22 15:10 PragmaTwice

Thanks, gets to work

aleksraiden avatar Oct 02 '22 16:10 aleksraiden