kvrocks icon indicating copy to clipboard operation
kvrocks copied to clipboard

Support flushall/flushdb option

Open shangxiaoxiong opened this issue 3 years ago • 2 comments

When flushall or flushdb is executed, the disk is still occupied until a compaction occurs. this may bring confusion to users because to free disk space quickly is expected in most case. this commit makes kvrocks support flushall/flushdb with option which decides whether to compact immediately. Note that compaction caused by flushall/flushdb will spread to slave.

supported options:

  • sync: delete data and compact immediately
  • async: delete data
  • none: the same with sync

shangxiaoxiong avatar Jan 06 '22 06:01 shangxiaoxiong

l found a bug through test and l am locating

shangxiaoxiong avatar Jan 11 '22 03:01 shangxiaoxiong

@shangxiaoxiong solved?

ShooterIT avatar Jan 25 '22 02:01 ShooterIT

Closed as stale.

Codebase evolves a lot since the last activities on this patch. @shangxiaoxiong you're welcome to propose the changes again based on the nightly unstable branch.

tisonkun avatar Aug 16 '22 14:08 tisonkun