kvrocks icon indicating copy to clipboard operation
kvrocks copied to clipboard

feat: add CLIENT PAUSE and CLIENT REPLY subcommands

Open furkan-bilgin opened this issue 1 year ago • 3 comments

This PR is a part of #2422

I have added two subcommands for the command CLIENT:

  • CLIENT PAUSE: Pauses processing of either WRITE or ALL commands until after timeout milliseconds.
  • CLIENT REPLY: Stops server from sending replies to the client, starting; immediately if OFF, or skips one if SKIP. Starts sending replies if ON.

furkan-bilgin avatar Aug 18 '24 14:08 furkan-bilgin

@furkan-bilgin Thanks for your contribution. Could you please help to pass the CI lint according to https://github.com/apache/kvrocks/actions/runs/10441248380/job/28912245323?pr=2495

git-hulk avatar Aug 18 '24 14:08 git-hulk

@furkan-bilgin Looks good if you can add some Go test cases to cover this. And another point is that we should disable the EV_READ for connection while pausing?

git-hulk avatar Sep 06 '24 05:09 git-hulk