kvrocks icon indicating copy to clipboard operation
kvrocks copied to clipboard

Confusing error message while failed to parse the cluster slots

Open spihiker opened this issue 1 year ago • 4 comments

Search before asking

  • [X] I had searched in the issues and found no similar issues.

Version

v2.9.0

Minimal reproduce step

CLUSTERX SETNODES "86f7e437faa5a7fce15d1ddcb9eaeaea377667b8 172.20.84.154 6666 master - 0-5460 3c363836cf4e16666669a25da280a1865c2d2874 172.20.84.154 6669 slave 86f7e437faa5a7fce15d1ddcb9eaeaea377667b8" 1 (error) ERR Slot is out of range

What did you expect to see?

normal as redis.

What did you see instead?

no

Anything Else?

no

Are you willing to submit a PR?

  • [ ] I'm willing to submit a PR!

spihiker avatar Jul 11 '24 09:07 spihiker

Could you try to add a \n?

CLUSTERX SETNODES "86f7e437faa5a7fce15d1ddcb9eaeaea377667b8 172.20.84.154 6666 master - 0-5460 \n  3c363836cf4e16666669a25da280a1865c2d2874 172.20.84.154 6669 slave 86f7e437faa5a7fce15d1ddcb9eaeaea377667b8" 1

PragmaTwice avatar Jul 11 '24 09:07 PragmaTwice

After add a \n.It can run normally.Thank you.

spihiker avatar Jul 12 '24 00:07 spihiker

@PragmaTwice @spihiker This error message is very confusing for users, I have changed the issue title to track and improve it.

git-hulk avatar Jul 12 '24 04:07 git-hulk

@PragmaTwice @git-hulk Would this be more of a parser change vs. a changed error messsage? Is using '\n' the proper way to do it?

jonathanc-n avatar Aug 14 '24 01:08 jonathanc-n

This can be closed

jonathanc-n avatar Sep 22 '24 16:09 jonathanc-n

@jonathanc-n Thank you!

git-hulk avatar Sep 23 '24 00:09 git-hulk