kvrocks
kvrocks copied to clipboard
refactor(stream): change the encoding of stream consumer group
The encoding way of stream consumer group is not efficient, this PR changes the encoding according to this discussion.
Should StreamEntryID::Maximum be {UINT64_MAX - 1, ..} to avoid the -1 case here?
Can we merge this PR?
@Yangsx-1 You can merge PR once the CI passed
There is one issue that needs to be considered: after the modification, the case where EID MS is -1 needs to be excluded when traversing (iterating) all sub-keys (EID MS|EID SEQ).
As I mentioned here.
There is one issue that needs to be considered: after the modification, the case where
EID MSis -1 needs to be excluded when traversing (iterating) all sub-keys (EID MS|EID SEQ).As I mentioned here.
It's been changed now.
Hi @torwig, could you please review this PR when you have some time?
@PragmaTwice Sure. I'll review it today.
@Yangsx-1 @PragmaTwice Since we have UINT64_MAX as a delimiter, should it be an invalid seq of the stream entry ID?
Should we consider changing code here, here and here?
@Yangsx-1 @PragmaTwice Since we have
UINT64_MAXas a delimiter, should it be an invalidseqof the stream entry ID? Should we consider changing code here, here and here?
Yes, i'll change these code later.
Quality Gate failed
Failed conditions
C Reliability Rating on New Code (required ≥ A)
See analysis details on SonarCloud
Catch issues before they fail your Quality Gate with our IDE extension
SonarLint