kvrocks icon indicating copy to clipboard operation
kvrocks copied to clipboard

refactor(stream): change the encoding of stream consumer group

Open Yangsx-1 opened this issue 1 year ago • 1 comments

The encoding way of stream consumer group is not efficient, this PR changes the encoding according to this discussion.

Yangsx-1 avatar Jun 29 '24 14:06 Yangsx-1

Should StreamEntryID::Maximum be {UINT64_MAX - 1, ..} to avoid the -1 case here?

PragmaTwice avatar Jul 01 '24 13:07 PragmaTwice

Can we merge this PR?

Yangsx-1 avatar Jul 07 '24 13:07 Yangsx-1

@Yangsx-1 You can merge PR once the CI passed

git-hulk avatar Jul 10 '24 13:07 git-hulk

There is one issue that needs to be considered: after the modification, the case where EID MS is -1 needs to be excluded when traversing (iterating) all sub-keys (EID MS|EID SEQ).

As I mentioned here.

PragmaTwice avatar Jul 10 '24 13:07 PragmaTwice

There is one issue that needs to be considered: after the modification, the case where EID MS is -1 needs to be excluded when traversing (iterating) all sub-keys (EID MS|EID SEQ).

As I mentioned here.

It's been changed now.

Yangsx-1 avatar Jul 11 '24 15:07 Yangsx-1

Hi @torwig, could you please review this PR when you have some time?

PragmaTwice avatar Jul 15 '24 05:07 PragmaTwice

@PragmaTwice Sure. I'll review it today.

torwig avatar Jul 15 '24 05:07 torwig

@Yangsx-1 @PragmaTwice Since we have UINT64_MAX as a delimiter, should it be an invalid seq of the stream entry ID? Should we consider changing code here, here and here?

torwig avatar Jul 15 '24 18:07 torwig

@Yangsx-1 @PragmaTwice Since we have UINT64_MAX as a delimiter, should it be an invalid seq of the stream entry ID? Should we consider changing code here, here and here?

Yes, i'll change these code later.

Yangsx-1 avatar Jul 16 '24 09:07 Yangsx-1

Quality Gate Failed Quality Gate failed

Failed conditions
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

sonarqubecloud[bot] avatar Jul 16 '24 18:07 sonarqubecloud[bot]