kvrocks
kvrocks copied to clipboard
Rethink `USE_ALIGNED_ACCESS` macro in kvrocks code
Search before asking
- [X] I had searched in the issues and found no similar issues.
Motivation
Redis uses USE_ALIGNED_ACCESS and check memory aligned in it's code:
- For archs like ARM, memory access should be "aligned".
- For arch like x86, it can use some code to do optimizations
This code leaves lots of ad-hoc optimizations in kvrocks. I think we need to check our compiler supports, does this really provides any optimizations
Solution
- Checks
USE_ALIGNED_ACCESSin code with compiler versions - Remove them if no really optimizations
Are you willing to submit a PR?
- [X] I'm willing to submit a PR!