kvrocks icon indicating copy to clipboard operation
kvrocks copied to clipboard

Reduce the number of write buffers for infrequently used column families

Open git-hulk opened this issue 1 year ago • 9 comments

Search before asking

  • [X] I had searched in the issues and found no similar issues.

Motivation

Currently, all column families are shared the same number of write buffers which is unnecessary for infrequently used column families including pubsub, propagte, and zset_score. We can keep them to a const value like 1 to reduce the memory usage in some scenarios.

Solution

No response

Are you willing to submit a PR?

  • [ ] I'm willing to submit a PR!

git-hulk avatar Mar 23 '24 10:03 git-hulk

Please assign it to me, thanks a lot :D

LiuYuHui avatar Mar 23 '24 15:03 LiuYuHui

@LiuYuHui Thank you!

git-hulk avatar Mar 23 '24 15:03 git-hulk

Hi @LiuYuHui Are you still working on this issue?

git-hulk avatar Apr 09 '24 04:04 git-hulk

Hi @git-hulk, I have had no extra time bandwidth recently, please feel free to assign it to other people.

LiuYuHui avatar Apr 09 '24 15:04 LiuYuHui

@LiuYuHui Thanks for your quick response. Welcome back while you get time.

git-hulk avatar Apr 10 '24 13:04 git-hulk

Hi @git-hulk , May i question? How do we implement this feature?

  1. For each column family add a config, specifying its number of write buffers. eg: pubsub.max_write_buffer_numberpropagte.max_write_buffer_numberzset_score.max_write_buffer_number ...
  2. Add a lite mode config, When this config is set to true, create a new lite_table_opts for infrequently used column families. like:
rocksdb::BlockBasedTableOptions lite_table_opts = InitTableOptions();
rocksdb::ColumnFamilyOptions lite_opts(subkey_opts);
lite_opts.write_buffer_size = 32 * MiB;
lite_opts.max_write_buffer_number = 0;

// replace subkey_opts with lite_opts 
column_families.emplace_back(kZSetScoreColumnFamilyName, lite_opts);
column_families.emplace_back(kPubSubColumnFamilyName, lite_opts);
column_families.emplace_back(kPropagateColumnFamilyName, lite_opts);
column_families.emplace_back(kStreamColumnFamilyName, lite_opts);```

jjz921024 avatar Apr 10 '24 15:04 jjz921024

@jjz921024 Yes, I'm good with this implementation. Would you like to submit a PR?

git-hulk avatar Apr 11 '24 02:04 git-hulk

Yes, I want to try

jjz921024 avatar Apr 12 '24 13:04 jjz921024

@jjz921024 Assigned, thank you!

git-hulk avatar Apr 12 '24 13:04 git-hulk