kvrocks icon indicating copy to clipboard operation
kvrocks copied to clipboard

Allow to use hyper clock cache to replace the LRU cache

Open git-hulk opened this issue 1 year ago • 5 comments

Search before asking

  • [X] I had searched in the issues and found no similar issues.

Motivation

The hyperclock cache was introduced in rocksdb in 7.7.3 and it may bring performance benefits for the block/row cache while compared to the LRU cache. This idea is mentioned by @PragmaTwice.

Solution

Allow to enable the hyper cache via the configuration.

Are you willing to submit a PR?

  • [ ] I'm willing to submit a PR!

git-hulk avatar Jan 15 '24 14:01 git-hulk

hello! I have a question for this. Noticed that this issue has a need benchmark tag, is there a standard way to benchmark kvrocks? For example, does simlply running redis-benchmark on my computer is enough , or we need to do some other experiments on some platforms?

JxLi0921 avatar Jan 16 '24 14:01 JxLi0921

@JxLi0921 Your local environment is enough. What we want to know is if the hyper clock cache can bring performance benefits while compared to LRU. And the benchmark result is also not a blocking item for merging PR.

git-hulk avatar Jan 16 '24 15:01 git-hulk

Noticed that this issue has a need benchmark tag, is there a standard way to benchmark kvrocks?

Perhaps you can try ycsb in your local environment. This is a way we can follow: https://github.com/apache/kvrocks/pull/1424#issuecomment-1546521178

mapleFU avatar Jan 16 '24 15:01 mapleFU

@git-hulk @mapleFU Thanks for your answers, got it! Could you please assign this to me? I would like to give it a try.

JxLi0921 avatar Jan 16 '24 15:01 JxLi0921

@JxLi0921 assigned, thank you!

git-hulk avatar Jan 17 '24 02:01 git-hulk

It seems like that this issue had been solved?

LiuYuHui avatar Mar 09 '24 06:03 LiuYuHui

@LiuYuHui Sorry for forgetting to close this issue, it's done in #2031.

git-hulk avatar Mar 09 '24 07:03 git-hulk