kvrocks
kvrocks copied to clipboard
Allow to use hyper clock cache to replace the LRU cache
Search before asking
- [X] I had searched in the issues and found no similar issues.
Motivation
The hyperclock cache was introduced in rocksdb in 7.7.3 and it may bring performance benefits for the block/row cache while compared to the LRU cache. This idea is mentioned by @PragmaTwice.
Solution
Allow to enable the hyper cache via the configuration.
Are you willing to submit a PR?
- [ ] I'm willing to submit a PR!
hello! I have a question for this. Noticed that this issue has a need benchmark tag, is there a standard way to benchmark kvrocks? For example, does simlply running redis-benchmark on my computer is enough , or we need to do some other experiments on some platforms?
@JxLi0921 Your local environment is enough. What we want to know is if the hyper clock cache can bring performance benefits while compared to LRU. And the benchmark result is also not a blocking item for merging PR.
Noticed that this issue has a need benchmark tag, is there a standard way to benchmark kvrocks?
Perhaps you can try ycsb in your local environment. This is a way we can follow: https://github.com/apache/kvrocks/pull/1424#issuecomment-1546521178
@git-hulk @mapleFU Thanks for your answers, got it! Could you please assign this to me? I would like to give it a try.
@JxLi0921 assigned, thank you!
It seems like that this issue had been solved?
@LiuYuHui Sorry for forgetting to close this issue, it's done in #2031.