kvrocks icon indicating copy to clipboard operation
kvrocks copied to clipboard

support transcation processing for `cluster setslot`

Open infdahai opened this issue 1 year ago • 4 comments

Search before asking

  • [X] I had searched in the issues and found no similar issues.

Motivation

Originally posted by @infdahai in https://github.com/apache/incubator-kvrocks/pull/1414#discussion_r1185736226

Cluster::SetSlotRanges exists consistency issues if slot in the middle is down https://github.com/apache/incubator-kvrocks/blob/d2d10f7dd220992a2c7cf9f1b44a96a6c6ac80a7/src/cluster/cluster.cc#L123-L145

Solution

@caipengbo

Are you willing to submit a PR?

  • [ ] I'm willing to submit a PR!

infdahai avatar May 14 '23 11:05 infdahai

BTW, two places exist in cluster.cc. We should find a solution to delete all the range in a write batch.

infdahai avatar Jun 18 '23 18:06 infdahai

@infdahai is this still relevant?

ameya-deshmukh avatar Sep 06 '23 17:09 ameya-deshmukh

@ameya-deshmukh Yes, would you like to take this?

git-hulk avatar Sep 07 '23 01:09 git-hulk

Yep!

ameya-deshmukh avatar Sep 07 '23 02:09 ameya-deshmukh