kvrocks-website icon indicating copy to clipboard operation
kvrocks-website copied to clipboard

Update docusaurus.config.js to enable dark mode switch

Open asad-awadia opened this issue 1 year ago • 6 comments

Screenshot 2024-03-12 160504

asad-awadia avatar Mar 13 '24 12:03 asad-awadia

I remember we ever banned it because the homepage would have a dirty look (style incompatible)?

tisonkun avatar Mar 13 '24 12:03 tisonkun

@tisonkun Yes, but it looks good for now(from my personal perspective).

image

git-hulk avatar Mar 13 '24 13:03 git-hulk

image @tisonkun Yes, but it looks good for now(from my personal perspective).

Really good? I cannot understand your point. The home page looks really bad in dark mode:

  • The banner is still in light mode.
  • Buttons are still in light mode.
  • Namespace icon has a white rectangular frame.

PragmaTwice avatar Mar 13 '24 13:03 PragmaTwice

Sorry but we need a good overall solution of dark mode.

Not just enable the dark mode switch.

PragmaTwice avatar Mar 13 '24 13:03 PragmaTwice

Sorry but we need a good overall solution of dark mode.

I will whip up an HLD for it :)

Perfection is the enemy of good and things can be added incrementally

But in all seriousness, the dark mode looks great for all pages - homepage looks off because the assets aren't dark mode but I can't update those

asad-awadia avatar Mar 13 '24 13:03 asad-awadia

image @tisonkun Yes, but it looks good for now(from my personal perspective).

Really good? I cannot understand your point. The home page looks really bad in dark mode:

  • The banner is still in light mode.
  • Buttons are still in light mode.
  • Namespace icon has a white rectangular frame.

😭 Maybe I have a bad sense of web UI, so I think those inconsistent colors between them are good for me. Also the reason why I just mentioned that's my perspective.

git-hulk avatar Mar 13 '24 13:03 git-hulk