knox icon indicating copy to clipboard operation
knox copied to clipboard

KNOX-3046 - Yarn REST API should support query parameters

Open slankka opened this issue 1 year ago • 1 comments

(It is very important that you created an Apache Knox JIRA for this change and that the PR title/commit message includes the Apache Knox JIRA ID!)

What changes were proposed in this pull request?

Knox Gateway for Yarn ResourceManager REST API should respect query parameters.

The conclusion is: {**}?{**} works and {**} will ignore query params.

How was this patch tested?

There is already one can prove that patten {**}?{**} works with query parameters and without parameters.

https://github.com/apache/knox/blob/d21cf8f63944afdd5d4ffa0236a16cd788d9a14a/gateway-provider-rewrite/src/test/java/org/apache/knox/gateway/filter/rewrite/api/UrlRewriteProcessorTest.java#L274-L303

and rewrite.xml :

https://github.com/apache/knox/blob/d21cf8f63944afdd5d4ffa0236a16cd788d9a14a/gateway-provider-rewrite/src/test/resources/org/apache/knox/gateway/filter/rewrite/api/UrlRewriteProcessorTest/rewrite.xml#L22-L25

slankka avatar Jun 21 '24 12:06 slankka

@pzampino , @moresandeep - it seems that the conversation topics are resolved here. If this is good to go, we should get it in prior to 2.1.0 branching which is will happen shortly.

lmccay avatar Oct 20 '24 17:10 lmccay