kibble-1 icon indicating copy to clipboard operation
kibble-1 copied to clipboard

Introduce pylint to increase code quality

Open turbaszek opened this issue 4 years ago • 3 comments

Description Introduce pylint for code quality analysis: https://github.com/PyCQA/pylint

This can be easily done by adding a respectable hook to our pre-commit configuration. However, this may require a lot of changes to code and maybe better to split it into few commits in single PR.

Use case Increase code quality, follow Python community best practices and avoid regression in future.

Related Issues N/A

turbaszek avatar Oct 11 '20 17:10 turbaszek

I will do it. Everyone loves quality. :) https://www.youtube.com/watch?v=jbJ6Ufl5Kkc&ab_channel=MichaelFish

michalslowikowski00 avatar Oct 17 '20 08:10 michalslowikowski00

Ok, it will require more work, as you said. Before submitting this PR'a I will fix the code to make it compliant with pylint: part by part. There will be few PR's. :)

michalslowikowski00 avatar Oct 21 '20 20:10 michalslowikowski00

@michalslowikowski00 the amount of work will depend on the number of errors. We can reduce them by adding more rules to ignored ones in pylintrc config file

turbaszek avatar Oct 22 '20 09:10 turbaszek