kafka icon indicating copy to clipboard operation
kafka copied to clipboard

KAFKA-1194 Forces unmapping of buffer if on Windows

Open mmanna-sapfgl opened this issue 7 years ago • 2 comments

In response to KAFKA-1194 issue, it now forces buffer to unmap if running on Windows OS. Invdividual Unit Test 'testChangeFileSuffixes' on LogSegmentTest.scala passes. but other file IO related unit tests still fail on Windows (Which is irrelevant to this code change).

mmanna-sapfgl avatar Apr 30 '18 13:04 mmanna-sapfgl

@guozhangwang or @vahidhashemian could we get this reviewed by one of the members? This is a change long overdue, and we have to build this into kafka release every time we want to upgrade. The relevant test testChangeFileSuffixes in LogSegmentTest.scala passes on Windows and Linux successfully.

mmanna-sapfgl avatar May 08 '18 10:05 mmanna-sapfgl

This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please leave a comment asking for a review. If the PR has merge conflicts, update it with the latest from the base branch.

If you are having difficulty finding a reviewer, please reach out on the [mailing list](https://kafka.apache.org/contact).

If this PR is no longer valid or desired, please feel free to close it. If no activity occurs in the next 30 days, it will be automatically closed.

github-actions[bot] avatar Oct 21 '24 03:10 github-actions[bot]

This PR has been closed since it has not had any activity in 120 days. If you feel like this was a mistake, or you would like to continue working on it, please feel free to re-open the PR and ask for a review.

github-actions[bot] avatar Nov 21 '24 03:11 github-actions[bot]