kafka icon indicating copy to clipboard operation
kafka copied to clipboard

KAFKA 5609 - Added RollingFileAppender as per review comments

Open asutosh936 opened this issue 7 years ago • 4 comments

More detailed description of your change, if necessary. The PR title and PR message become the squashed commit message, so use a separate comment to ping reviewers.

Summary of testing strategy (including rationale) for the feature or bug fix. Unit and/or integration tests are expected for any behaviour change and system tests should be considered for larger changes.

Committer Checklist (excluded from commit message)

  • [ ] Verify design and implementation
  • [ ] Verify test coverage and CI build status
  • [ ] Verify documentation (including upgrade notes)

asutosh936 avatar Mar 22 '18 01:03 asutosh936

@rnpridgeon @ewencp @cotedm @rhauch @guozhangwang

Guys very sorry, have some issues with Git repo and the branch having this fix got deleted. Hence have made the necessary requested changes and have to create new Pull Request.

This is reference to previous PR https://github.com/apache/kafka/pull/4687

Let me know if any further changes are needed.

asutosh936 avatar Apr 08 '18 16:04 asutosh936

Guys any update on this PR?

asutosh936 avatar Apr 24 '18 00:04 asutosh936

@guozhangwang can someone from Your team review and merge.

asutosh936 avatar May 18 '18 00:05 asutosh936

This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please leave a comment asking for a review. If the PR has merge conflicts, update it with the latest from the base branch.

If you are having difficulty finding a reviewer, please reach out on the [mailing list](https://kafka.apache.org/contact).

If this PR is no longer valid or desired, please feel free to close it. If no activity occurs in the next 30 days, it will be automatically closed.

github-actions[bot] avatar Oct 21 '24 03:10 github-actions[bot]

This PR has been closed since it has not had any activity in 120 days. If you feel like this was a mistake, or you would like to continue working on it, please feel free to re-open the PR and ask for a review.

github-actions[bot] avatar Nov 20 '24 03:11 github-actions[bot]