kafka icon indicating copy to clipboard operation
kafka copied to clipboard

MINOR: use bash regex matching instead of egrep inside kafka-run-class.sh

Open kurnevsky opened this issue 7 years ago • 2 comments

It seems there is no reason to call egrep for each including jar since bash support regex matching. The reason of why this change might be useful is that we use kafka-run-class.sh for healthcheck and have audit enabled for exec so every launch of healthcheck produces a lot of audit logs. Besides egrep is deprecated.

kurnevsky avatar Feb 19 '18 09:02 kurnevsky

LGTM

cmccabe avatar Feb 20 '18 18:02 cmccabe

This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please leave a comment asking for a review. If the PR has merge conflicts, update it with the latest from the base branch.

If you are having difficulty finding a reviewer, please reach out on the [mailing list](https://kafka.apache.org/contact).

If this PR is no longer valid or desired, please feel free to close it. If no activity occurs in the next 30 days, it will be automatically closed.

github-actions[bot] avatar Oct 21 '24 03:10 github-actions[bot]

This PR has been closed since it has not had any activity in 120 days. If you feel like this was a mistake, or you would like to continue working on it, please feel free to re-open the PR and ask for a review.

github-actions[bot] avatar Nov 20 '24 03:11 github-actions[bot]