kafka icon indicating copy to clipboard operation
kafka copied to clipboard

KAFKA-6303: Potential lack of synchronization in NioEchoServer

Open shivsantham opened this issue 8 years ago • 1 comments

In the run() method:

                            SocketChannel socketChannel = ((ServerSocketChannel) key.channel()).accept();
                            socketChannel.configureBlocking(false);
                            newChannels.add(socketChannel);

Modification to newChannels should be protected by synchronized block.

  • [ ] Verify design and implementation
  • [x] Verify test coverage and CI build status
  • [ ] Verify documentation (including upgrade notes)

shivsantham avatar Jan 07 '18 06:01 shivsantham

This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please leave a comment asking for a review. If the PR has merge conflicts, update it with the latest from the base branch.

If you are having difficulty finding a reviewer, please reach out on the [mailing list](https://kafka.apache.org/contact).

If this PR is no longer valid or desired, please feel free to close it. If no activity occurs in the next 30 days, it will be automatically closed.

github-actions[bot] avatar Oct 21 '24 03:10 github-actions[bot]

This PR has been closed since it has not had any activity in 120 days. If you feel like this was a mistake, or you would like to continue working on it, please feel free to re-open the PR and ask for a review.

github-actions[bot] avatar Nov 20 '24 03:11 github-actions[bot]