kafka icon indicating copy to clipboard operation
kafka copied to clipboard

KAFKA-4893: Fix conflict between async topic deletion and max topic length

Open vahidhashemian opened this issue 8 years ago • 7 comments

With async topic deletion the topic partition folder name is affixed with a '.', a UUID, and '-delete'. If topic name length is close to its current limit (249) this could cause an issue because the folder name size goes over 255. This PR implements the suggestion solution by @onurkaraman in the JIRA. This implementation is automatically backward compatible, and cleans up any folder marked for deletion using the old method (affixing the folder name).

vahidhashemian avatar Nov 21 '17 00:11 vahidhashemian

Does this PR handle the case where a kafka cluster already has a topic called delete? And, does it prevent a topic from being created that is called delete?

wushujames avatar Nov 21 '17 00:11 wushujames

@wushujames With this PR we can still have a topic named delete. The -# affix of topic partition folders would not cause a conflict with the newly introduced delete folder. Does it make sense?

vahidhashemian avatar Nov 21 '17 00:11 vahidhashemian

Ah, right. All the other directories are topic-partitionnum. Thanks.

wushujames avatar Nov 21 '17 00:11 wushujames

@onurkaraman Since there was no additional feedback on the JIRA, I submitted the PR hoping the conversation continues here. Thanks in advance for reviewing.

vahidhashemian avatar Nov 21 '17 17:11 vahidhashemian

@onurkaraman I'd appreciate your feedback when you have a chance to review this PR. Thanks.

vahidhashemian avatar Jan 18 '18 21:01 vahidhashemian

@onurkaraman pinging you again to check if you could take a look. If not, perhaps @hachikuji can help. Thanks!

vahidhashemian avatar Mar 19 '18 15:03 vahidhashemian

This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please leave a comment asking for a review. If the PR has merge conflicts, update it with the latest from the base branch.

If you are having difficulty finding a reviewer, please reach out on the [mailing list](https://kafka.apache.org/contact).

If this PR is no longer valid or desired, please feel free to close it. If no activity occurs in the next 30 days, it will be automatically closed.

github-actions[bot] avatar Oct 21 '24 03:10 github-actions[bot]

This PR has been closed since it has not had any activity in 120 days. If you feel like this was a mistake, or you would like to continue working on it, please feel free to re-open the PR and ask for a review.

github-actions[bot] avatar Nov 20 '24 03:11 github-actions[bot]