kafka icon indicating copy to clipboard operation
kafka copied to clipboard
verified publisher icon apache

KAFKA-6163 fail fast on startup

Open xvrl opened this issue 8 years ago • 5 comments

skip loading remaining logs if we encounter an unrecoverable error on startup

@hachikuji @ijuma

xvrl avatar Nov 06 '17 16:11 xvrl

FAILURE No test results found. --none--

asfgit avatar Nov 06 '17 19:11 asfgit

FAILURE 7942 tests run, 5 skipped, 1 failed. --none--

asfgit avatar Nov 06 '17 20:11 asfgit

SUCCESS 8050 tests run, 5 skipped, 0 failed. --none--

asfgit avatar Nov 06 '17 20:11 asfgit

The fix LGTM. I am wondering how much trouble it would be to have a test case. Say if we only have one recovery thread and we attempt to load two logs; if the first one fails, maybe we can assert that the second one never gets loaded?

hachikuji avatar Nov 27 '17 22:11 hachikuji

This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please leave a comment asking for a review. If the PR has merge conflicts, update it with the latest from the base branch.

If you are having difficulty finding a reviewer, please reach out on the [mailing list](https://kafka.apache.org/contact).

If this PR is no longer valid or desired, please feel free to close it. If no activity occurs in the next 30 days, it will be automatically closed.

github-actions[bot] avatar Oct 18 '24 03:10 github-actions[bot]

This PR has been closed since it has not had any activity in 120 days. If you feel like this was a mistake, or you would like to continue working on it, please feel free to re-open the PR and ask for a review.

github-actions[bot] avatar Nov 18 '24 03:11 github-actions[bot]