kafka icon indicating copy to clipboard operation
kafka copied to clipboard

Update kafka-server-stop.sh

Open pengkeboy opened this issue 8 years ago • 4 comments

This script does not work on Kafka1.0. Kafka1.0 work well to use this script to stop the process.

pengkeboy avatar Nov 06 '17 07:11 pengkeboy

@pengkeboy you haven't referenced any reported issue. Please read https://cwiki.apache.org/confluence/display/KAFKA/Contributing+Code+Changes

tombentley avatar Nov 06 '17 09:11 tombentley

I dont think that is a good way for handling this, if you have other kafka related instance running(e.g. mirrormaker or 2nd kafka instance running in the same box). this script might kill the wrong application. I think the proper way would be have a pid file.

lisa2lisa avatar Jan 30 '18 08:01 lisa2lisa

I went with a different approach maybe thats more appropiate: https://github.com/apache/kafka/pull/4487

AlexanderThaller avatar Jan 30 '18 11:01 AlexanderThaller

This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please leave a comment asking for a review. If the PR has merge conflicts, update it with the latest from the base branch.

If you are having difficulty finding a reviewer, please reach out on the [mailing list](https://kafka.apache.org/contact).

If this PR is no longer valid or desired, please feel free to close it. If no activity occurs in the next 30 days, it will be automatically closed.

github-actions[bot] avatar Oct 18 '24 03:10 github-actions[bot]

This PR has been closed since it has not had any activity in 120 days. If you feel like this was a mistake, or you would like to continue working on it, please feel free to re-open the PR and ask for a review.

github-actions[bot] avatar Nov 18 '24 03:11 github-actions[bot]