KAFKA-19980: ConfigCommand#validatePropsKey should accept `$` symbol
- Enabled ConfigCommand#validatePropsKey to support the
$symbol. - Added UT and IT for the change.
Reviewers: Chia-Ping Tsai [email protected]
@smjn Do you have a chance to take a look at this PR?
I am about to merge this. Since it is being shipped in trunk, we will have time to address any feedback in a follow-up PR
Thanks for fixing this issue!
It is good to document this change for users. When running from CLI, we have to include a trailing slash to escape the dollar:
The below one will change the logger level in ClientQuotaManager class not in ThrottledChannelReaper:
sh kafka-configs.sh --bootstrap-server localhost:9092 --broker-logger 0 --add-config org.apache.kafka.server.quota.ClientQuotaManager$ThrottledChannelReaper=DEBUG --alter
Valid command:
sh kafka-configs.sh --bootstrap-server localhost:9092 --broker-logger 0 --add-config org.apache.kafka.server.quota.ClientQuotaManager\$ThrottledChannelReaper=DEBUG --alter
Feel free to ignore, added this comment for user reference when they hit/check this PR.
It is good to document this change for users. When running from CLI, we have to include a trailing slash to escape the dollar:
That makes sense. @DL1231 Could you address this comment with a minor patch?
@kamalcph @chia7712
Thanks for the tip! I've added a comment in the code to highlight the need for escaping the $ symbol in CLI usage. This should help users understand the context.
PR: https://github.com/apache/kafka/pull/21186