kafka icon indicating copy to clipboard operation
kafka copied to clipboard

KAFKA-19980: ConfigCommand#validatePropsKey should accept `$` symbol

Open DL1231 opened this issue 1 month ago • 1 comments

  1. Enabled ConfigCommand#validatePropsKey to support the $ symbol.
  2. Added UT and IT for the change.

Reviewers: Chia-Ping Tsai [email protected]

DL1231 avatar Dec 11 '25 07:12 DL1231

@smjn Do you have a chance to take a look at this PR?

chia7712 avatar Dec 11 '25 14:12 chia7712

I am about to merge this. Since it is being shipped in trunk, we will have time to address any feedback in a follow-up PR

chia7712 avatar Dec 12 '25 14:12 chia7712

Thanks for fixing this issue!

kamalcph avatar Dec 12 '25 18:12 kamalcph

It is good to document this change for users. When running from CLI, we have to include a trailing slash to escape the dollar:

The below one will change the logger level in ClientQuotaManager class not in ThrottledChannelReaper:

sh kafka-configs.sh --bootstrap-server localhost:9092 --broker-logger 0 --add-config org.apache.kafka.server.quota.ClientQuotaManager$ThrottledChannelReaper=DEBUG --alter

Valid command:

sh kafka-configs.sh --bootstrap-server localhost:9092 --broker-logger 0 --add-config org.apache.kafka.server.quota.ClientQuotaManager\$ThrottledChannelReaper=DEBUG --alter

Feel free to ignore, added this comment for user reference when they hit/check this PR.

kamalcph avatar Dec 17 '25 10:12 kamalcph

It is good to document this change for users. When running from CLI, we have to include a trailing slash to escape the dollar:

That makes sense. @DL1231 Could you address this comment with a minor patch?

chia7712 avatar Dec 17 '25 12:12 chia7712

@kamalcph @chia7712 Thanks for the tip! I've added a comment in the code to highlight the need for escaping the $ symbol in CLI usage. This should help users understand the context. PR: https://github.com/apache/kafka/pull/21186

DL1231 avatar Dec 20 '25 01:12 DL1231