kafka icon indicating copy to clipboard operation
kafka copied to clipboard
verified publisher icon apache

MINOR: Cleanup ShareFetchAcknowledgeRequestTest

Open sjhajharia opened this issue 7 months ago • 3 comments

Now that Kafka supports Java 17, this PR cleans up the ShareFetchAcknowledgeRequestTest. The changes mostly include:

  • Collections.singletonList() is replaced with List.of()
  • Get rid of all asJava conversions

sjhajharia avatar May 29 '25 18:05 sjhajharia

Thanks @m1a2st I have addressed the comments

sjhajharia avatar May 30 '25 04:05 sjhajharia

Hey @frankvicky / @chia7712 , Inviting you for reviews too. Thanks!

sjhajharia avatar Jun 03 '25 08:06 sjhajharia

Gentle reminder @frankvicky @chia7712

sjhajharia avatar Jun 11 '25 04:06 sjhajharia

@sjhajharia please fix the conflicts

chia7712 avatar Jun 21 '25 16:06 chia7712

Thanks @chia7712 I just fixed the conficts.

sjhajharia avatar Jun 21 '25 17:06 sjhajharia