kafka icon indicating copy to clipboard operation
kafka copied to clipboard

MINOR: Cleanup JMH-Benchmarks Module

Open sjhajharia opened this issue 7 months ago • 8 comments

Now that Kafka supports Java 17, this PR makes some changes in jmh-benchmarks module. The changes mostly include:

  • Collections.emptyList(), Collections.singletonList() and Arrays.asList() are replaced with List.of()
  • Collections.emptyMap() and Collections.singletonMap() are replaced with Map.of()
  • Collections.singleton() is replaced with Set.of()

sjhajharia avatar May 23 '25 04:05 sjhajharia

Thanks for the PR. Could you also do this cleanup? Collections.unmodifiableMap -> Map.copyOf

Yunyung avatar May 23 '25 15:05 Yunyung

Thanks @Yunyung for the review. I have addressed the comment. PTAL when possible!

sjhajharia avatar May 23 '25 17:05 sjhajharia

Please resolve the conflict, thanks

m1a2st avatar May 26 '25 03:05 m1a2st

Hey @m1a2st I have updated the PR

sjhajharia avatar May 26 '25 11:05 sjhajharia

cc: @frankvicky

sjhajharia avatar May 28 '25 10:05 sjhajharia

Hey @frankvicky If you can pls have a look at this PR too.

sjhajharia avatar May 31 '25 06:05 sjhajharia

Gentle reminder @frankvicky @chia7712

sjhajharia avatar Jun 05 '25 12:06 sjhajharia

Gentle reminder @chia7712 @frankvicky

sjhajharia avatar Jun 11 '25 04:06 sjhajharia

Hey @chia7712 Gentle reminder!

sjhajharia avatar Jul 01 '25 13:07 sjhajharia