KAFKA-18884: Move TransactionMetadata to transaction-coordinator module
- Move TransactionMetadata to transaction-coordinator module.
- Rewrite TransactionMetadata in Java.
@chia7712, I addressed all comments. Could you review again when you have time? Thanks.
@chia7712 Thanks for the suggestion. I address all comments.
If we aren't ready to merge this yet, I would also like to review sometime this week. (If that's ok!)
@jolshan any review is welcome. Thank you. 👍
@FrankYang0529 Just remainder, there is a conflict.
convert this PR to draft to wait for KAFKA-15370
Convert this PR to draft to wait for KAFKA-15370
Artem will be out for a few weeks, so we can complete this PR. Thanks for cooperation!
Convert this PR to draft to wait for KAFKA-15370
Artem will be out for a few weeks, so we can complete this PR. Thanks for cooperation!
Thanks. I will fix conflicts and address comments tomorrow.
@FrankYang0529 @chia7712 How are things going here? I can help review if we need to get it over the line.
cc: @artemlivshits @rreddy-22
I just merged trunk, but CI cannot pass. I need some time to fix these. Thanks.
Thanks for the PR! Can we update the description a bit to explain some of the changes? Like specifically how the state transitions work with the java class. In scala, we could convert to transit metadata from transaction metadata by using the methods that only changed the values we needed. If we could briefly sketch how this works in the new model, that would help.
I open https://issues.apache.org/jira/browse/KAFKA-19609 to move the related tests to transaction-coordinator module