kafka icon indicating copy to clipboard operation
kafka copied to clipboard

KAFKA-18884: Move TransactionMetadata to transaction-coordinator module

Open FrankYang0529 opened this issue 7 months ago • 6 comments

  1. Move TransactionMetadata to transaction-coordinator module.
  2. Rewrite TransactionMetadata in Java.

FrankYang0529 avatar May 13 '25 04:05 FrankYang0529

@chia7712, I addressed all comments. Could you review again when you have time? Thanks.

FrankYang0529 avatar May 20 '25 15:05 FrankYang0529

@chia7712 Thanks for the suggestion. I address all comments.

FrankYang0529 avatar May 24 '25 09:05 FrankYang0529

If we aren't ready to merge this yet, I would also like to review sometime this week. (If that's ok!)

jolshan avatar Jun 10 '25 20:06 jolshan

@jolshan any review is welcome. Thank you. 👍

FrankYang0529 avatar Jun 11 '25 06:06 FrankYang0529

@FrankYang0529 Just remainder, there is a conflict.

TaiJuWu avatar Jun 13 '25 08:06 TaiJuWu

convert this PR to draft to wait for KAFKA-15370

chia7712 avatar Jun 18 '25 01:06 chia7712

Convert this PR to draft to wait for KAFKA-15370

Artem will be out for a few weeks, so we can complete this PR. Thanks for cooperation!

jolshan avatar Jul 01 '25 16:07 jolshan

Convert this PR to draft to wait for KAFKA-15370

Artem will be out for a few weeks, so we can complete this PR. Thanks for cooperation!

Thanks. I will fix conflicts and address comments tomorrow.

FrankYang0529 avatar Jul 01 '25 16:07 FrankYang0529

@FrankYang0529 @chia7712 How are things going here? I can help review if we need to get it over the line.

cc: @artemlivshits @rreddy-22

jolshan avatar Aug 06 '25 19:08 jolshan

I just merged trunk, but CI cannot pass. I need some time to fix these. Thanks.

FrankYang0529 avatar Aug 07 '25 14:08 FrankYang0529

Thanks for the PR! Can we update the description a bit to explain some of the changes? Like specifically how the state transitions work with the java class. In scala, we could convert to transit metadata from transaction metadata by using the methods that only changed the values we needed. If we could briefly sketch how this works in the new model, that would help.

jolshan avatar Aug 07 '25 21:08 jolshan

I open https://issues.apache.org/jira/browse/KAFKA-19609 to move the related tests to transaction-coordinator module

chia7712 avatar Aug 15 '25 18:08 chia7712