kafka icon indicating copy to clipboard operation
kafka copied to clipboard

KAFKA-18966: Change controller_num_nodes_override to override_num_isolated_controllers

Open CalvinConfluent opened this issue 8 months ago • 4 comments
trafficstars

Bounce the broker that hosting the controller can cause unnecessary downtime for the partition. Avoid creating only 1 controller node in the combined kraft mode. For more details please check https://issues.apache.org/jira/browse/KAFKA-18966

CalvinConfluent avatar Mar 12 '25 18:03 CalvinConfluent

@CalvinConfluent Could you please share the tests to me? I'd like to test it on my local to ensure it does reduce the test time.

chia7712 avatar Mar 13 '25 14:03 chia7712

@chia7712 Thanks for checking. It is the transactions_test.py where Combined_kraft and hard_bounce are used. The transaction timeout is 40s, in my environment, the controller restart time(broker restart + controller starting handle ISR updates) is very close to 40s which makes the test flaky. I may update the PR a bit.

CalvinConfluent avatar Mar 13 '25 16:03 CalvinConfluent

@chia7712 Can you help take another look?

CalvinConfluent avatar Mar 18 '25 17:03 CalvinConfluent

This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please leave a comment asking for a review. If the PR has merge conflicts, update it with the latest from the base branch.

If you are having difficulty finding a reviewer, please reach out on the [mailing list](https://kafka.apache.org/contact).

If this PR is no longer valid or desired, please feel free to close it. If no activity occurs in the next 30 days, it will be automatically closed.

github-actions[bot] avatar Jun 18 '25 03:06 github-actions[bot]

This PR has been closed since it has not had any activity in 120 days. If you feel like this was a mistake, or you would like to continue working on it, please feel free to re-open the PR and ask for a review.

github-actions[bot] avatar Jul 18 '25 03:07 github-actions[bot]