kafka icon indicating copy to clipboard operation
kafka copied to clipboard

Add a SelectorProvider that reuses custom provider implementations.

Open DimitarMilushev opened this issue 9 months ago • 3 comments

Tasks:

  • [x] Add a custom SelectorProvider.
  • [x] Update Selector to utilize the custom SelectorProvider.

Changes:

The SelectorProvider fixes an issue where the static method Selector.open() would create a system-wide default SelectorProvider object whereas in our case we need a custom SelectorProvider. This implementation utilizes ThreadLocal so that each thread can reuse the configured provider within its' own context.

The Selector code is updated to use our custom SelectorProvider from org.apache.kafka.common.network.

DimitarMilushev avatar Mar 11 '25 15:03 DimitarMilushev

A label of 'needs-attention' was automatically added to this PR in order to raise the attention of the committers. Once this issue has been triaged, the triage label should be removed to prevent this automation from happening again.

github-actions[bot] avatar Mar 19 '25 03:03 github-actions[bot]

This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please leave a comment asking for a review. If the PR has merge conflicts, update it with the latest from the base branch.

If you are having difficulty finding a reviewer, please reach out on the [mailing list](https://kafka.apache.org/contact).

If this PR is no longer valid or desired, please feel free to close it. If no activity occurs in the next 30 days, it will be automatically closed.

github-actions[bot] avatar Jun 17 '25 03:06 github-actions[bot]

A label of 'needs-attention' was automatically added to this PR in order to raise the attention of the committers. Once this issue has been triaged, the triage label should be removed to prevent this automation from happening again.

github-actions[bot] avatar Jun 19 '25 03:06 github-actions[bot]

This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please leave a comment asking for a review. If the PR has merge conflicts, update it with the latest from the base branch.

If you are having difficulty finding a reviewer, please reach out on the [mailing list](https://kafka.apache.org/contact).

If this PR is no longer valid or desired, please feel free to close it. If no activity occurs in the next 30 days, it will be automatically closed.

github-actions[bot] avatar Sep 17 '25 03:09 github-actions[bot]

This pull rquest is still relevant. Could you please review it?

This PR will help us updating to more recent Kafka clients versions as we have some own SelectorProvider we use, and the integration will be much easier. Thx!

matheis avatar Sep 18 '25 10:09 matheis

A label of 'needs-attention' was automatically added to this PR in order to raise the attention of the committers. Once this issue has been triaged, the triage label should be removed to prevent this automation from happening again.

github-actions[bot] avatar Sep 19 '25 03:09 github-actions[bot]