apache
KAFKA-10789: Streamlining Tests in ChangeLoggingKeyValueBytesStoreTest
- use mocked
InMemoryKeyValueStoreto streamlined the unit test - minor refactor including remove unnecessary
publicand rename the variable inside the method with a different name with outside of the method.
Committer Checklist (excluded from commit message)
- [x] Verify design and implementation
- [x] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
A label of 'needs-attention' was automatically added to this PR in order to raise the
attention of the committers. Once this issue has been triaged, the triage label
should be removed to prevent this automation from happening again.
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
A label of 'needs-attention' was automatically added to this PR in order to raise the
attention of the committers. Once this issue has been triaged, the triage label
should be removed to prevent this automation from happening again.
Hi @chia7712, in the CI process, there are three flaky tests that are unrelated to this PR. Could you let me know how to re-run the CI process to get them to pass?
A label of 'needs-attention' was automatically added to this PR in order to raise the
attention of the committers. Once this issue has been triaged, the triage label
should be removed to prevent this automation from happening again.
@mjsax Thanks for the review! Please let me know if there's anything else I should address.
Hi @mjsax, It seems like the user is not responding I have done some progress, on this ticket. Can I assign this ticket to myself and create a PR?
@leaf-soba -- Are you still interested to complete this PR?
Truly sorry I focused on landing a new job overseas last months, please feel free to assign the PR to other people.