KAFKA-18061 AddRaftVoter responds with error message "NONE" instead of null
Fix building 'Response.errorMessage' with 'RaftUtil #addVoterResponse' and' RaftUtil#removeVoterResponse' for 'Errors.NONE' is not 'null' but 'NONE' because When 'errorMessage' is passed in as 'null', 'Errors#message' is used to generate a default value, and this method is a friendly result.
Summary of testing strategy (including rationale) for the feature or bug fix. Unit and/or integration tests are expected for any behaviour change and system tests should be considered for larger changes.
Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
This failed test has been fixed in KAFKA-18078
Is it possible to add some test for this?
@aiven-anton ok
@jsancio Sure, done
@ahuang98 @jsancio Is it possible to get this merged for 3.9.1?
@ahuang98 @jsancio , any other comment for this PR?
Bumping this one again, possible to get this merged?
@Linsiyuan9 Do you have free time to fix the conflicts? If not, we will take over it
@Linsiyuan9 Do you have free time to fix the conflicts? If not, we will take over it
Sorry, I just saw the message. I'll handle it.
the flaky is traced by https://issues.apache.org/jira/browse/KAFKA-14533
Thanks for fixing this! 🙏