kafka icon indicating copy to clipboard operation
kafka copied to clipboard

KAFKA-18061 AddRaftVoter responds with error message "NONE" instead of null

Open Linsiyuan9 opened this issue 1 year ago • 7 comments

Fix building 'Response.errorMessage' with 'RaftUtil #addVoterResponse' and' RaftUtil#removeVoterResponse' for 'Errors.NONE' is not 'null' but 'NONE' because When 'errorMessage' is passed in as 'null', 'Errors#message' is used to generate a default value, and this method is a friendly result.

Summary of testing strategy (including rationale) for the feature or bug fix. Unit and/or integration tests are expected for any behaviour change and system tests should be considered for larger changes.

Committer Checklist (excluded from commit message)

  • [ ] Verify design and implementation
  • [ ] Verify test coverage and CI build status
  • [ ] Verify documentation (including upgrade notes)

Linsiyuan9 avatar Nov 24 '24 06:11 Linsiyuan9

This failed test has been fixed in KAFKA-18078

Linsiyuan9 avatar Nov 24 '24 09:11 Linsiyuan9

Is it possible to add some test for this?

aiven-anton avatar Nov 27 '24 16:11 aiven-anton

@aiven-anton ok

Linsiyuan9 avatar Nov 28 '24 02:11 Linsiyuan9

@jsancio Sure, done

Linsiyuan9 avatar Jan 16 '25 05:01 Linsiyuan9

@ahuang98 @jsancio Is it possible to get this merged for 3.9.1?

aiven-anton avatar Apr 01 '25 11:04 aiven-anton

@ahuang98 @jsancio , any other comment for this PR?

showuon avatar Apr 11 '25 05:04 showuon

Bumping this one again, possible to get this merged?

aiven-anton avatar Jun 13 '25 11:06 aiven-anton

@Linsiyuan9 Do you have free time to fix the conflicts? If not, we will take over it

chia7712 avatar Aug 23 '25 19:08 chia7712

@Linsiyuan9 Do you have free time to fix the conflicts? If not, we will take over it

Sorry, I just saw the message. I'll handle it.

Linsiyuan9 avatar Sep 04 '25 08:09 Linsiyuan9

the flaky is traced by https://issues.apache.org/jira/browse/KAFKA-14533

chia7712 avatar Sep 08 '25 00:09 chia7712

Thanks for fixing this! 🙏

aiven-anton avatar Sep 09 '25 06:09 aiven-anton