kafka KAFKA-17813: Moving broker endpoint class and common server connection id

Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

Oct 16 '24 21:10 apoorvmittal10

@apoorvmittal10 I love this cleanup and migration. Could you please rebase code to fix conflicts as #17473 is already merged

Oct 17 '24 06:10 chia7712

@apoorvmittal10 I love this cleanup and migration. Could you please rebase code to fix conflicts as #17473 is already merged

Thanks @chia7712, sure. I ll force push the branch once https://github.com/apache/kafka/pull/17474 is also merged, as the changes are on top of that. Hence keeping the PR in draft mode till then.

Oct 17 '24 07:10 apoorvmittal10

@chia7712 Yeah, sorry https://github.com/apache/kafka/pull/17474 is not required for this PR. I have rebased it and marked for review. Please if you could take a look.

Oct 17 '24 07:10 apoorvmittal10

Looking into the tests failure.

Oct 17 '24 11:10 apoorvmittal10

@chia7712 @brandboat Thanks for the review, can you please re-look.

Oct 17 '24 17:10 apoorvmittal10

I have addressed the comments, 1 with the name is pending. If the name doesn't seems right for ServerConnectionId then I ll change it. Though I have added the class description.

Oct 17 '24 20:10 apoorvmittal10

I have resolved the comments, build passed.

Oct 18 '24 13:10 apoorvmittal10

@junrao Thanks for the feedback and review. Please let me know if I need to address more. Build has passes for the PR.

Oct 21 '24 17:10 apoorvmittal10

@junrao I have addressed the comment, removed brackets, corrected tests and comments. Please can you review.

Oct 22 '24 16:10 apoorvmittal10