kafka icon indicating copy to clipboard operation
kafka copied to clipboard
verified publisher icon apache

KAFKA-17757: Remove Utils.mkEntry

Open mingyen066 opened this issue 1 year ago • 1 comments

Removes Utils#mkMap and Utils#mkEntry as JDK 9+ allows Map.ofEntries and Map.entry for creating immutable map.

Utils#mkMap will be handled in KAFKA-17820

Committer Checklist (excluded from commit message)

  • [ ] Verify design and implementation
  • [ ] Verify test coverage and CI build status
  • [ ] Verify documentation (including upgrade notes)

mingyen066 avatar Oct 13 '24 09:10 mingyen066

@mingyen066 Please check the CI

chia7712 avatar Oct 18 '24 02:10 chia7712

@mingyen066 please fix conflicts

chia7712 avatar Oct 30 '24 18:10 chia7712

Hi @chia7712, sorry for the late reply. I've migrated all the mkEntry usages to Map.entry, except for those used to create entries with null values.

mingyen066 avatar Nov 26 '24 19:11 mingyen066

@mingyen066 We should close this PR if we cannot completely remove Utils.mkEntry. Introducing these extensive changes to 4.0 at this stage provides no clear benefits. Thanks for your patch!

chia7712 avatar Nov 28 '24 18:11 chia7712